[edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi/AcpiTables: Update all tables to latest ACPI

[Ard Biesheuvel]

On 5/6/20 1:37 PM, Pete Batard wrote:
...
> Therefore, since we do see a need for ACPI 6.x features, and
> effectively have a 6.3 table with PPTT, and also since we have
> tested that we are not seeing ill effects from doing so for the
> most common OSes we support, we bring all of the relevant ACPI
> tables to version 6.3.
> 
> This is mostly accomplished by simply altering the version of
> ACPI being references in the macros,

OK, so even the macros that resolve to the exact same code are renamed. 
I suppose this means a blanket rename of everything once ACPI 6.4 comes out?

> except for the new fields
> being initialized in the MADT table where we:
> * Use 1 for GICR Base Address in GICC_STRUCTURE_INIT because, even
>    as this field is not supposed to apply to any of our platforms,
>    this is what Microsoft used in the original Pi 3 hardcoded MADT
>    blobs and Windows 10 doesn't boot on the Pi 3 if set to 0.

Fair enough.

> * Use 2 for GIC version in GIC_DISTRIBUTOR_INIT, since the Pi 4 GIC
>    is v2 only.
> 

OK. But you are introducing new references to ACPI_6_0 macros here. If 
the point is to rename everything for cosmetic reasons, shouldn't you 
use 6.3 there as well?

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58705): https://edk2.groups.io/g/devel/message/58705
Mute This Topic: https://groups.io/mt/74026589/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-