[edk2-devel] [PATCH edk2-platforms v4 0/9] BCM genet fixes

Ard Biesheuvel ard.biesheuvel at arm.com
Mon May 11 14:55:18 UTC 2020


This fixes the multicast/broadcast/promisc handling, and switches to
ordinary page allocations for RX buffers. Patch #1 is cosmetic only.

Note that these apply on top of the series sent out by Samer, and is
intended to be squashed into that series before merging.

Changes since v3:
- more cosmetic tweaks in #1
- move DmaUnmap() for TX buffers to the correct place
- use MemoryFence() instead of DSB for MMIO write ordering
- add unload support to the driver
- remove the Ax88772b driver from the RPi4 build - it is no longer needed,
  and misbehaves when no cable is connected.

Changes since v2:
- fix MDF filter handling (fixes issue reported by Samer)
- add patch to deal with ExitBootServices() so we don't leave the RX DMA
  ring running when we enter the OS

https://github.com/pftf/edk2-platforms/tree/rpi4_genet_v4_ardb

Cc: Pete Batard <pete at akeo.ie>
Cc: Jared McNeill <jmcneill at invisible.ca>
Cc: Andrei Warkentin <awarkentin at vmware.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>
Cc: Jeremy Linton <jeremy.linton at arm.com>

Ard Biesheuvel (9):
  Silicon/Broadcom/BcmGenetDxe: whitespace/cosmetic cleanup
  Silicon/Broadcom/BcmGenetDxe: add support for broadcast filtering
  Silicon/Broadcom/BcmGenetDxe: fix multicast/broadcast handling
  Silicon/Broadcom/BcmGenetDxe: avoid uncached memory for streaming DMA
  Silicon/Broadcom/BcmGenetDxe: shut down devices on ExitBootServices()
  Silicon/Broadcom/BcmGenetDxe: keep TX buffer mapped during DMA
    transfer
  Silicon/Broadcom/BcmGenetDxe: use MemoryFence() for MMIO write
    ordering
  Silicon/Broadcom/BcmGenetDxe: add unload support
  Platform/RaspberryPi4: remove ASIX 88772b driver

 Platform/RaspberryPi/RPi4/RPi4.dsc            |   1 -
 Platform/RaspberryPi/RPi4/RPi4.fdf            |   1 -
 .../Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf   |  13 +-
 .../Drivers/Net/BcmGenetDxe/GenetUtil.h       |  51 +-
 .../Drivers/Net/BcmGenetDxe/DriverBinding.c   | 122 ++-
 .../Drivers/Net/BcmGenetDxe/GenericPhy.c      |  16 +-
 .../Drivers/Net/BcmGenetDxe/GenetUtil.c       | 787 +++++++++---------
 .../Drivers/Net/BcmGenetDxe/SimpleNetwork.c   | 115 ++-
 8 files changed, 621 insertions(+), 485 deletions(-)

-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59082): https://edk2.groups.io/g/devel/message/59082
Mute This Topic: https://groups.io/mt/74137442/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list