[edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid

Tue May 12 15:00:41 UTC 2020

Hi Liming.

The intention of this patch series was to add headers to MdePkg, to make it possible start working on features implementation.
Implementing all features in all affected files through all possible module was not in my intentions at all.
I agreed to change DxeCapsuleLib to speed up adoption of this series. We need this headers ASAP to start implementing those features in our own products.  So we need headers before  soft freeze.

Regards, Oleksiy.

-----Original Message-----
From: Gao, Liming [mailto:liming.gao at intel.com]
Sent: Tuesday, May 12, 2020 10:07 AM
To: Oleksiy Yakovlev; devel at edk2.groups.io
Cc: Feng, Bob C; Kinney, Michael D; Felix Polyudov
Subject: RE: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid

MdeModulePkg\Universal\SerialDxe and MdeModulePkg\Bus\Pci\PciSioSerialDxe are two drivers to install SerialIo protocol with the original structure. Please see below code logic. With this patch, SERIAL_IO_INTERFACE_REVISION macro is updated to 1.1. But, this protocol doesn't set the value for new field DeviceTypeGuid. So, I want to confirm whether NULL DeviceTypeGuid is valid or not.

EFI_SERIAL_IO_PROTOCOL mSerialIoTemplate = {
  SERIAL_IO_INTERFACE_REVISION,
  SerialReset,
  SerialSetAttributes,
  SerialSetControl,
  SerialGetControl,
  SerialWrite,
  SerialRead,
  &mSerialIoMode
};

> -----Original Message-----
> From: Oleksiy Yakovlev <Oleksiyy at ami.com>
> Sent: Tuesday, May 12, 2020 10:01 PM
> To: Gao, Liming <liming.gao at intel.com>; devel at edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng at intel.com>; Kinney, Michael D <michael.d.kinney at intel.com>; Felix Polyudov <Felixp at ami.com>
> Subject: RE: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid
>
> Hi Liming.
>
> I did not understand your question about MdeModulePkg\Universal\SerialDxe and MdeModulePkg\Bus\Pci\PciSioSerialDxe
>
> Regards, Oleksiy.
>
> -----Original Message-----
> From: Gao, Liming [mailto:liming.gao at intel.com]
> Sent: Monday, May 11, 2020 8:52 PM
> To: devel at edk2.groups.io; Oleksiy Yakovlev
> Cc: Feng, Bob C; Kinney, Michael D; Felix Polyudov
> Subject: RE: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid
>
> Oleksiy:
>   Seemly, this patch doesn't response to my comment. Is there the comments to be added for new field DeviceTypeGuid? Can its
> value be NULL? And, are MdeModulePkg\Universal\SerialDxe and MdeModulePkg\Bus\Pci\PciSioSerialDxe required to be updated
> together?
>
> Thanks
> Liming
> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Oleksiy Yakovlev
> Sent: 2020年5月12日 4:19
> To: devel at edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng at intel.com>; Gao, Liming <liming.gao at intel.com>; Kinney, Michael D <michael.d.kinney at intel.com>;
> Felixp at ami.com; oleksiyy at ami.com
> Subject: [edk2-devel] [PATCH v5 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid
>
> EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001.
> CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure.
> UEFI 2.8 mantis 1832.
>
> Signed-off-by: Oleksiy Yakovlev <oleksiyy at ami.com>
>
> Reviewed-by: Liming Gao <liming.gao at intel.com>
> ---
>  MdePkg/Include/Protocol/SerialIo.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/Protocol/SerialIo.h b/MdePkg/Include/Protocol/SerialIo.h
> index 51eaa53..b2398c2 100644
> --- a/MdePkg/Include/Protocol/SerialIo.h
> +++ b/MdePkg/Include/Protocol/SerialIo.h
> @@ -262,7 +262,7 @@ typedef struct {
>    UINT32  StopBits;
>  } EFI_SERIAL_IO_MODE;
>
> -#define EFI_SERIAL_IO_PROTOCOL_REVISION    0x00010000
> +#define EFI_SERIAL_IO_PROTOCOL_REVISION    0x00010001
>  #define SERIAL_IO_INTERFACE_REVISION  EFI_SERIAL_IO_PROTOCOL_REVISION
>
>  ///
> @@ -287,6 +287,7 @@ struct _EFI_SERIAL_IO_PROTOCOL {
>    /// Pointer to SERIAL_IO_MODE data.
>    ///
>    EFI_SERIAL_IO_MODE          *Mode;
> +  CONST EFI_GUID               *DeviceTypeGuid; // Revision 1.1
>  };
>
>  extern EFI_GUID gEfiSerialIoProtocolGuid;
> --
> 2.9.0.windows.1
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication
> is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is
> not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please
> promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
>
> 
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication
> is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is
> not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please
> promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59289): https://edk2.groups.io/g/devel/message/59289
Mute This Topic: https://groups.io/mt/74144884/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-