[edk2-devel] [PATCH V7 0/1] Disable safe string constraint assertions

[Vitaly Cheptsov]

CC: Andrew Fish <afish at apple.com>
CC: Ard Biesheuvel <ard.biesheuvel at linaro.org>
CC: Bret Barkelew <bret.barkelew at microsoft.com>
CC: Brian J. Johnson <brian.johnson at hpe.com>
CC: Chasel Chiu <chasel.chiu at intel.com>
CC: Jordan Justen <jordan.l.justen at intel.com>
CC: Laszlo Ersek <lersek at redhat.com>
CC: Leif Lindholm <leif at nuviainc.com>
CC: Liming Gao <liming.gao at intel.com>
CC: Marvin Häuser <mhaeuser at outlook.de>
CC: Mike Kinney <michael.d.kinney at intel.com>
CC: Vincent Zimmer <vincent.zimmer at intel.com>
CC: Zhichao Gao <zhichao.gao at intel.com>

V7 addressed review comments (only documentation changes).

Current implementation of SafeString does not let one parse untrusted
data with its interfaces as they ASSERT on failing runtime checks and
require one to effectively reimplement the function on the caller side.

All the former proposals made it clear that the attempts to introduce
a solution preserving this behaviour require a lot of changes
throughout the codebase including platform code (e.g. introducing
constraint assertions and updating all DebugLib implementations)
or require all sorts of hacks.

Since the original code has roughly no benefit except in some very
special cases and the effort required to preserve it is very high,
I propose to remove it as agreed on with several other parties.

Please note, that this patch does not change the behaviour of the
functions in RELEASE builds. I.e. they will still check for NULL
and return RETURN_INVALID_PARAMETER. In the future we may (or may
not) want them to simply ASSERT in this case. Regardless this should
be done in a separate BZ entry and a separate commit. For this reason
I ask everyone not to touch this subject.

Due to the amount of discussion this has already undergone after
almost a year I kindly request everyone to reduce the communication
to the minimum and abstain from proposing another approach.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054

Requesting to merge this into edk2-stable202005.

Vitaly Cheptsov (1):
  MdePkg: Fix SafeString performing assertions on runtime checks

 MdePkg/Include/Library/BaseLib.h    | 111 -------------------
 MdePkg/Library/BaseLib/SafeString.c | 112 --------------------
 2 files changed, 223 deletions(-)

-- 
2.24.2 (Apple Git-127)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59578): https://edk2.groups.io/g/devel/message/59578
Mute This Topic: https://groups.io/mt/74210303/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-