[edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol

[Liming Gao]

https://github.com/tianocore/edk2/pull/625 is created for MdePkg change.

> -----Original Message-----
> From: Ni, Ray <ray.ni at intel.com>
> Sent: Friday, May 15, 2020 3:49 PM
> To: devel at edk2.groups.io; Ni, Ray <ray.ni at intel.com>; Gao, Liming <liming.gao at intel.com>; oleksiyy at ami.com
> Cc: Kinney, Michael D <michael.d.kinney at intel.com>; Felixp at ami.com; robert at ami.com
> Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol
> 
> I just sent out the change to update GetProcessorInfo() to return 6-level topology info.
> 
> The patch has been reviewed by Eric before pushing to edk2-staging repo.
> 
> Please tell me when the MdePkg/MpServices.h is merged.
> I will trigger the merge after that.
> 
> > -----Original Message-----
> > From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Ni, Ray
> > Sent: Friday, May 15, 2020 1:34 PM
> > To: Gao, Liming <liming.gao at intel.com>; devel at edk2.groups.io; oleksiyy at ami.com
> > Cc: Kinney, Michael D <michael.d.kinney at intel.com>; Felixp at ami.com; robert at ami.com
> > Subject: Re: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol
> >
> > sure I will.
> >
> > > -----Original Message-----
> > > From: Gao, Liming <liming.gao at intel.com>
> > > Sent: Friday, May 15, 2020 12:57 PM
> > > To: Ni, Ray <ray.ni at intel.com>; devel at edk2.groups.io; oleksiyy at ami.com
> > > Cc: Kinney, Michael D <michael.d.kinney at intel.com>; Felixp at ami.com; robert at ami.com
> > > Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol
> > >
> > > Ray:
> > >   I see https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b2ad706575f82e2fc also includes
> > the
> > > code change in UefiCpuPkg/Library/MpInitLib/MpLib.c. The change has passed review.
> > >
> > >   Can you send the separate patch for the change in UefiCpuPkg?
> > >
> > > Thanks
> > > Liming
> > > > -----Original Message-----
> > > > From: Ni, Ray <ray.ni at intel.com>
> > > > Sent: Monday, May 11, 2020 1:01 PM
> > > > To: devel at edk2.groups.io; oleksiyy at ami.com
> > > > Cc: Gao, Liming <liming.gao at intel.com>; Kinney, Michael D <michael.d.kinney at intel.com>; Felixp at ami.com;
> > > robert at ami.com
> > > > Subject: RE: [edk2-devel] [PATCH 5/5] MdePkg: Update structures for MpServices Protocol
> > > >
> > > > Robert,
> > > > I did similar change to MpService.h in
> > > > https://github.com/tianocore/edk2-staging/commit/2409b787fa196780e0fd101b2ad706575f82e2fc.
> > > >
> > > > My plan was to move the change to edk2 once the spec is published.
> > > > It seems your change doesn't conflict with my change. More comments are added in your change
> > > > which I think is better than mine.
> > > >
> > > > A minor comment to the comment in below.
> > > >
> > > > > +
> > > > > +/// Location2   The 6-level physical location of the processor, including the
> > > > > +///     physical package number that identifies the cartridge, the physical
> > > > > +///     module number within package, the physical tile number within the
> > > > > module,
> > > > > +///     the physical die number within the tile, the physical core number within
> > > > > +///     package, and logical thread number within core.
> > > >
> > > > Can you move the above comment to the line before "Location2" field and remove
> > > > the "Location2  "? It aligns to existing comments style.
> > > >
> > > > > +typedef union {
> > > > > +     EFI_CPU_PHYSICAL_LOCATION2  Location2;
> > > > > +} EXTENDED_PROCESSOR_INFORMATION;
> > > > > +
> > > > > +
> > > >
> > > > With that, Reviewed-by: Ray Ni <ray.ni at intel.com>
> > > >
> > >
> >
> >
> > 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59657): https://edk2.groups.io/g/devel/message/59657
Mute This Topic: https://groups.io/mt/74057701/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-