[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed incorrect commit template warnings
Ashley E Desimone
ashley.e.desimone at intel.com
Mon May 18 22:56:17 UTC 2020
Pushed: 39c498261c
-----Original Message-----
From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Bjorge, Erik C
Sent: Sunday, May 17, 2020 5:51 PM
To: devel at edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone at intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Pandya, Puja <puja.pandya at intel.com>; Bret Barkelew <Bret.Barkelew at microsoft.com>; Agyeman, Prince <prince.agyeman at intel.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed incorrect commit template warnings
The repo name was being passed in instead of the path the repo. This caused all commit templates to be flagged as warnings.
Cc: Ashley E Desimone <ashley.e.desimone at intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Cc: Puja Pandya <puja.pandya at intel.com>
Cc: Bret Barkelew <Bret.Barkelew at microsoft.com>
Cc: Prince Agyeman <prince.agyeman at intel.com>
Cc: Erik Bjorge <erik.c.bjorge at intel.com>
Signed-off-by: Erik Bjorge <erik.c.bjorge at intel.com>
---
edkrepo/commands/sync_command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/commands/sync_command.py b/edkrepo/commands/sync_command.py
index da99397..02e915d 100644
--- a/edkrepo/commands/sync_command.py
+++ b/edkrepo/commands/sync_command.py
@@ -200,7 +200,7 @@ class SyncCommand(EdkrepoCommand):
# Perform submodule updates and url redirection
maintain_submodules(repo_to_sync, repo)
# Update commit message templates
- update_repo_commit_template(workspace_path, repo, repo_to_sync, config, source_global_manifest_repo)
+ update_repo_commit_template(workspace_path, repo,
+ repo_to_sync, config, global_manifest_directory)
if sync_error:
print(SYNC_ERROR)
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#59769): https://edk2.groups.io/g/devel/message/59769
Mute This Topic: https://groups.io/mt/74282759/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list