[edk2-devel] [Patch v8 1/2] MdePkg: Fix SafeString performing assertions on runtime checks

[Laszlo Ersek]

On 05/20/20 05:11, Michael D Kinney wrote:
> From: Vitaly Cheptsov <vit9696 at protonmail.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054
> 
> Runtime checks returned via status return code should not work as
> assertions to permit parsing not trusted data with SafeString
> interfaces.  Replace ASSERT() with a DEBUG_VERBOSE message.
> 
> Cc: Andrew Fish <afish at apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> Cc: Bret Barkelew <bret.barkelew at microsoft.com>
> Cc: Brian J. Johnson <brian.johnson at hpe.com>
> Cc: Chasel Chiu <chasel.chiu at intel.com>
> Cc: Jordan Justen <jordan.l.justen at intel.com>
> Cc: Laszlo Ersek <lersek at redhat.com>
> Cc: Leif Lindholm <leif at nuviainc.com>
> Cc: Liming Gao <liming.gao at intel.com>
> Cc: Marvin H?user <mhaeuser at outlook.de>
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Cc: Vincent Zimmer <vincent.zimmer at intel.com>
> Cc: Zhichao Gao <zhichao.gao at intel.com>
> Cc: Jiewen Yao <jiewen.yao at intel.com>
> Signed-off-by: Vitaly Cheptsov <vit9696 at protonmail.com>
> ---
>  MdePkg/Include/Library/BaseLib.h    | 111 ---------------------------
>  MdePkg/Library/BaseLib/SafeString.c | 115 +---------------------------
>  2 files changed, 3 insertions(+), 223 deletions(-)

Reviewed-by: Laszlo Ersek <lersek at redhat.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59986): https://edk2.groups.io/g/devel/message/59986
Mute This Topic: https://groups.io/mt/74342113/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-