[edk2-devel] [PATCH edk2-platforms 01/16] Silicon/NXP/NxpQoriqLs.dec: Add PCIe related PCDs.

[Wasim Khan (OSS)]

> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel at arm.com>
> Sent: Friday, May 22, 2020 2:42 PM
> To: Wasim Khan (OSS) <wasim.khan at oss.nxp.com>; devel at edk2.groups.io;
> Meenakshi Aggarwal <meenakshi.aggarwal at nxp.com>; Vabhav Sharma
> <vabhav.sharma at nxp.com>; Varun Sethi <V.Sethi at nxp.com>;
> leif at nuviainc.com; jon at solid-run.com
> Cc: Wasim Khan <wasim.khan at nxp.com>
> Subject: Re: [PATCH edk2-platforms 01/16] Silicon/NXP/NxpQoriqLs.dec: Add
> PCIe related PCDs.
> 
> On 5/22/20 1:02 AM, Wasim Khan wrote:
> > From: Wasim Khan <wasim.khan at nxp.com>
> >
> > Add PCIe related PCDs.
> >
> > Signed-off-by: Vabhav Sharma <vabhav.sharma at nxp.com>
> 
> Please drop this signoff. This is not the correct way to acknowledge (co-
> )authorship.

Co-authored-by: Vabhav Sharma <vabhav.sharma at nxp.com>
Co-authored-by: Wasim Khan <wasim.khan at nxp.com>
Signed-off-by: Wasim Khan <wasim.khan at nxp.com>

Is this OK ?

> 
> > Signed-off-by: Wasim Khan <wasim.khan at nxp.com>
> > ---
> >   Silicon/NXP/NxpQoriqLs.dec | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> >
> > diff --git a/Silicon/NXP/NxpQoriqLs.dec b/Silicon/NXP/NxpQoriqLs.dec
> > index 0722f59ef4f6..bafdfd9f4298 100644
> > --- a/Silicon/NXP/NxpQoriqLs.dec
> > +++ b/Silicon/NXP/NxpQoriqLs.dec
> > @@ -27,3 +27,12 @@ [Guids.common]
> >   [PcdsFeatureFlag]
> >
> gNxpQoriqLsTokenSpaceGuid.PcdI2cErratumA009203|FALSE|BOOLEAN|0x0000
> 0315
> >
> >
> gNxpQoriqLsTokenSpaceGuid.PcdDcfgBigEndian|FALSE|BOOLEAN|0x00000316
> > +
> > +
> gNxpQoriqLsTokenSpaceGuid.PcdPciLutBigEndian|FALSE|BOOLEAN|0x0000031
> > + 7
> > +
> > +[PcdsFixedAtBuild.common]
> > +  # Pcds for PCI Express
> > +
> gNxpQoriqLsTokenSpaceGuid.PcdPciExp1BaseAddr|0x0|UINT64|0x00000500
> > +  gNxpQoriqLsTokenSpaceGuid.PcdNumPciController|0|UINT32|0x00000501
> > +  gNxpQoriqLsTokenSpaceGuid.PcdPcieLutBase|0x0|UINT32|0x00000502
> > +  gNxpQoriqLsTokenSpaceGuid.PcdPcieLutDbg|0x0|UINT32|0x00000503
> > +  gNxpQoriqLsTokenSpaceGuid.PcdPciDebug|FALSE|BOOLEAN|0x00000504
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60193): https://edk2.groups.io/g/devel/message/60193
Mute This Topic: https://groups.io/mt/74395372/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-