[EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

Tue May 26 16:13:43 UTC 2020

Samer,

Have you had a chance to review Mike’s PR process? Any thoughts as comparison?

- Bret
________________________________
From: devel at edk2.groups.io <devel at edk2.groups.io> on behalf of Samer El-Haj-Mahmoud via groups.io <samer.el-haj-mahmoud=arm.com at groups.io>
Sent: Tuesday, May 26, 2020 7:39:55 AM
To: rfc at edk2.groups.io <rfc at edk2.groups.io>; lersek at redhat.com <lersek at redhat.com>; Andrew Fish <afish at apple.com>
Cc: Bret Barkelew <Bret.Barkelew at microsoft.com>; devel at edk2.groups.io <devel at edk2.groups.io>; spbrogan at outlook.com <spbrogan at outlook.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Kinney, Michael D <michael.d.kinney at intel.com>; Leif Lindholm (Nuvia address) <leif at nuviainc.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>
Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

I agree with Andrew. I also found Laszlo's "unkempt guide" very useful. In addition, there is a short page by Peter Batard that adds more details on the commits validation, patchset generation, and e-mail submission: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2Fpbatard%2Fec1c9d1dd6e7144b07a09b057b1735a8&data=02%7C01%7Cbret.barkelew%40microsoft.com%7Cdca587d1198049354a6f08d80182b15a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637261008123224059&sdata=e%2Bk1gQubOWY8gWlQAUAmjIIaqQMv6p%2FMqjUHcntVm1g%3D&reserved=0

> -----Original Message-----
> From: rfc at edk2.groups.io <rfc at edk2.groups.io> On Behalf Of Laszlo Ersek
> via groups.io
> Sent: Tuesday, May 26, 2020 7:18 AM
> To: Andrew Fish <afish at apple.com>
> Cc: Bret Barkelew <Bret.Barkelew at microsoft.com>; devel at edk2.groups.io;
> spbrogan at outlook.com; rfc at edk2.groups.io; Desimone, Nathaniel L
> <nathaniel.l.desimone at intel.com>; Mike Kinney
> <michael.d.kinney at intel.com>; Leif Lindholm (Nuvia address)
> <leif at nuviainc.com>
> Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based
> Code Review Process
>
> On 05/25/20 20:28, Andrew Fish wrote:
> >
> >
> >> On May 25, 2020, at 11:10 AM, Laszlo Ersek <lersek at redhat.com> wrote:
> >>
> >> Hi Andrew,
> >>
> >> On 05/25/20 06:09, Andrew Fish wrote:
> >>
> >>> I also found I had to Bing/Google to find the detailed instructions
> >>> I needed as a developer, as the Wiki seems to assume you just know
> >>> the Linux kernel patch process. That feels like an area we can improve.
> >>
> >> (apologies if I've lost context; please disregard my message below in
> >> that case).
> >>
> >> I wrote the following wiki article originally in 2016:
> >>
> >> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FLaszlo%27s-unkemp&data=02%7C01%7Cbret.barkelew%40microsoft.com%7Cdca587d1198049354a6f08d80182b15a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637261008123224059&sdata=hwAXd7kabi4mQyTEr7AWlEyA4yHDkdwG8zr1lirgmA4%3D&reserved=0
> >> t-git-guide-for-edk2-contributors-and-maintainers
> >>
> >> I wrote it specifically for developers & maintainers with no (or
> >> almost
> >> no) prior git / mailing list experience. Multiple developers
> >> confirmed later that the article had helped them.
> >>
> >
> > Laszlo,
> >
> > Your wiki article was very very helpful. I just could not find it from the
> Tianocre wiki. It would be good if we could link to it from here [1], maybe as
> add to this: "Are you new to using git? If so, then the New to git page may be
> helpful."?
>
> The article at [1] is an official document, while the "unkempt guide" is not
> official. The unkempt guide starts by deferring to [1]. I didn't think the official
> document should point to my unofficial one, and/or we should create a loop
> of links.
>
> That said, if someone else updates [1] with a pointer, I won't protest.
> That's just something that I (having authored the unkempt guide) would not
> propose myself.
>
> I do agree that the wiki search facilities on github are basic. What has mostly
> worked for me is clicking the Pages arrow, and then entering a *very simple*
> search term in the drop-down search box. For example, if I do that now, and
> only enter "git", then the "unkempt guide" is listed (with other hits of
> course). I think this search box is basically for searching article titles.
>
> >
> > There are a lot folks who use git but don't use the email based review so
> they have never setup git with emali before. Your wiki, plus me figuring out
> the magic internal SMTP reflector (I reached out on an internal git malling list)
> is what got me unblocked.
>
> It's great that you have access to such infrastructure at Apple!
>
> Thanks!
> Laszlo
>
>
> >
> > [1]
> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FEDK-II-Developme&data=02%7C01%7Cbret.barkelew%40microsoft.com%7Cdca587d1198049354a6f08d80182b15a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637261008123234063&sdata=UqY5uoxqMamf5PkFLOJ20YKE1aWTZRqGnEYuK93AxiA%3D&reserved=0
> > nt-Process
> >
> > Thanks,
> >
> > Andrew Fish
> >
> >> Thanks
> >> Laszlo
> >>
> >
>
>
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60285): https://edk2.groups.io/g/devel/message/60285
Mute This Topic: https://groups.io/mt/74450665/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20200526/37950b19/attachment.htm>