[edk2-devel] [EXT] RE: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer Limit 65535 in R/W.

[Gaurav Jain]

Hi Leif

Tein Hock has reviewed this patch.
Please help to merge in edk2.

Regards
Gaurav Jain

> -----Original Message-----
> From: Loh, Tien Hock <tien.hock.loh at intel.com>
> Sent: Thursday, April 30, 2020 6:47 AM
> To: Leif Lindholm <leif at nuviainc.com>
> Cc: Pankaj Bansal <pankaj.bansal at nxp.com>; Ard Biesheuvel
> <ard.biesheuvel at arm.com>; Gaurav Jain <gaurav.jain at nxp.com>;
> Meenakshi Aggarwal <meenakshi.aggarwal at nxp.com>;
> devel at edk2.groups.io; Haojian Zhuang <haojian.zhuang at linaro.org>; Varun
> Sethi <V.Sethi at nxp.com>
> Subject: [EXT] RE: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock
> Transfer Limit 65535 in R/W.
> 
> Caution: EXT Email
> 
> Hi Leif,
> 
> Yes, that's a Reviewed-by.
> 
> Thanks.
> 
> > -----Original Message-----
> > From: Leif Lindholm <leif at nuviainc.com>
> > Sent: Wednesday, April 29, 2020 7:16 PM
> > To: Loh, Tien Hock <tien.hock.loh at intel.com>
> > Cc: Pankaj Bansal <pankaj.bansal at nxp.com>; Ard Biesheuvel
> > <ard.biesheuvel at arm.com>; Gaurav Jain <gaurav.jain at nxp.com>;
> Meenakshi
> > Aggarwal <meenakshi.aggarwal at nxp.com>; devel at edk2.groups.io;
> Haojian
> > Zhuang <haojian.zhuang at linaro.org>; Varun Sethi <V.Sethi at nxp.com>
> > Subject: Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock
> Transfer
> > Limit 65535 in R/W.
> >
> > Hi Tien Hock,
> >
> > Can I take that as a Reviewed-by:?
> >
> > Regards,
> >
> > Leif
> >
> > On Wed, Apr 29, 2020 at 05:17:18 +0000, Loh, Tien Hock wrote:
> > > Hi Ard,
> > >
> > > I have checked the patch and it looks good.
> > >
> > > However, I can no longer test the patch as the new DwMmc driver no
> > > longer
> > uses the protocol.
> > > Sorry for the delay, I initially thought I can test it until I
> > > investigated further
> > today.
> > >
> > > Thanks
> > >
> > >
> > > > -----Original Message-----
> > > > From: Pankaj Bansal <pankaj.bansal at nxp.com>
> > > > Sent: Monday, April 27, 2020 2:19 PM
> > > > To: Ard Biesheuvel <ard.biesheuvel at arm.com>; Leif Lindholm
> > > > <leif at nuviainc.com>; Gaurav Jain <gaurav.jain at nxp.com>; Meenakshi
> > > > Aggarwal <meenakshi.aggarwal at nxp.com>
> > > > Cc: devel at edk2.groups.io; Haojian Zhuang
> > > > <haojian.zhuang at linaro.org>; Loh, Tien Hock
> > > > <tien.hock.loh at intel.com>; Varun Sethi <V.Sethi at nxp.com>
> > > > Subject: RE: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock
> > Transfer
> > > > Limit 65535 in R/W.
> > > >
> > > > + Meenakshi
> > > >
> > > > > -----Original Message-----
> > > > > From: Ard Biesheuvel <ard.biesheuvel at arm.com>
> > > > > Sent: Monday, April 6, 2020 7:42 PM
> > > > > To: Leif Lindholm <leif at nuviainc.com>; Gaurav Jain
> > > > > <gaurav.jain at nxp.com>
> > > > > Cc: devel at edk2.groups.io; Pankaj Bansal <pankaj.bansal at nxp.com>;
> > > > > Haojian Zhuang <haojian.zhuang at linaro.org>; Loh, Tien Hock
> > > > > <tien.hock.loh at intel.com>
> > > > > Subject: Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock
> > > > > Transfer Limit 65535 in R/W.
> > > > >
> > > > > On 4/6/20 4:08 PM, Leif Lindholm wrote:
> > > > > > Hi Gaurav,
> > > > > >
> > > > > > Haojian, Tien Hock - can you help review/test this change?
> > > > > >
> > > > > > Best Regards,
> > > > > >
> > > > > > Leif
> > > > > >
> > > > > > On Fri, Apr 03, 2020 at 14:54:07 +0530, Gaurav Jain wrote:
> > > > > >> Moved BlockCount calculation below BufferSize Validation checks.
> > > > > >> First Ensure Buffersize is Not Zero and multiple of Media BlockSize.
> > > > > >> then calculate BlockCount and perform Block checks.
> > > > > >>
> > > > > >> Corrected BlockCount calculation, as BufferSize is multiple
> > > > > >> of BlockSize, So adding (BlockSize-1) bytes to BufferSize and
> > > > > >> then divide by BlockSize will have no impact on BlockCount.
> > > > > >>
> > > > > >> Reading Large Images from MMC causes errors.
> > > > > >> As per SD Host Controller Spec version 4.20, Restriction of
> > > > > >> 16-bit Block Count transfer is 65535.
> > > > > >> Max block transfer limit in single cmd is 65535 blocks.
> > > > > >> Added Max Block check that can be processed is 0xFFFF.
> > > > > >> then Update BlockCount on the basis of MaxBlock.
> > > > > >>
> > > > > >> Signed-off-by: Gaurav Jain <gaurav.jain at nxp.com>
> > > > >
> > > > >
> > > > > Hello Gaurav,
> > > > >
> > > > > Could you please elaborate on the underlying need for this change?
> > > > > If you are considering using this driver for future NXP
> > > > > platforms, I should point out that this legacy driver is only
> > > > > kept around for existing users, and new users should use the
> > > > > driver stack in MdeModulePkg, which is based on the UEFI spec.
> > > > >
> > > > > --
> > > > > Ard.
> > > > >
> > > > >
> > > > >
> > >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60335): https://edk2.groups.io/g/devel/message/60335
Mute This Topic: https://groups.io/mt/74497516/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-