[edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

[Michael D Kinney]

Hi Leif,

The reason for this statement is not for performance.

It is if the same include file exists in the same path
in more than one package.  Defining this behavior makes
the build system deterministic.

There is use case where a platform package can provide
an include override of a common package and the platform
modules list the platform package before the common
package in the [Packages] section.

So deterministic build when there are include file 
name collisions and overrides are 2 reasons to keep
the currently defined behavior.

With this background, perhaps some clarification or
rewording of the spec is required?  Do you have suggestions?

Thanks,

Mike

  This is not a common use case,
but one that does apply is a platform module that wants
to use an override of a standard include file in a platform
package.

For the build system autogen stage, this statement 

Mike

> -----Original Message-----
> From: Leif Lindholm <leif at nuviainc.com>
> Sent: Friday, May 29, 2020 7:03 AM
> To: devel at edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney at intel.com>;
> Andrew Fish <afish at apple.com>; Laszlo Ersek
> <lersek at redhat.com>; Pankaj Bansal
> <pankaj.bansal at oss.nxp.com>
> Subject: [PATCH edk2-InfSpecification] Drop statement
> on package ordering
> 
> The description of [Packages] sections stated that
> "Packages must be listed in the order that may be
> required for specifying
>  include path statements for a compiler. For example,
> the
>  MdePkg/MdePkg.dec file must be listed before the
>  MdeModulePkg/MdeModulePkg.dec file."
> 
> Drop it.
> 
> Signed-off-by: Leif Lindholm <leif at nuviainc.com>
> ---
> 
> Surely this isn't something we take seriously?
> If there is a measurable performance impact to the
> order of -I option
> on the compiler command line, we should approach this
> programmatically.
> 
>  3_edk_ii_inf_file_format/37_[packages]_sections.md | 7
> ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git
> a/3_edk_ii_inf_file_format/37_[packages]_sections.md
> b/3_edk_ii_inf_file_format/37_[packages]_sections.md
> index 17a8d91..c09112b 100644
> ---
> a/3_edk_ii_inf_file_format/37_[packages]_sections.md
> +++
> b/3_edk_ii_inf_file_format/37_[packages]_sections.md
> @@ -42,11 +42,8 @@ Defines the `[Packages]` section tag
> that is used in EDK II module INF files.
>  Each entry in this section contains a directory name,
> forward slash character
>  and the name of the DEC file contained in the
> directory name.
> 
> -Packages must be listed in the order that may be
> required for specifying
> -include path statements for a compiler. For example,
> the _MdePkg/MdePkg.dec_
> -file must be listed before the
> `MdeModulePkg/MdeModulePkg.dec` file. If there
> -are PCDs listed in the generated "As Built" INF, the
> packages that declare any
> -PCDs must be listed in this section.
> +If there are PCDs listed in the generated "As Built"
> INF, the packages that
> +declare any PCDs must be listed in this section.
> 
>  Each package filename must be listed only once per
> section. Package filenames
>  listed in architectural sections are not permitted to
> be listed in the common
> --
> 2.20.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60477): https://edk2.groups.io/g/devel/message/60477
Mute This Topic: https://groups.io/mt/74544111/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-