[edk2-devel] [RedfishPkg PATCH v2 1/4] RedfishPkg: Initial commit of RedfishPkg.

[Laszlo Ersek]

On 09/30/20 03:56, changab wrote:
> Initial version of RedfishPkg.
> 
> Signed-off-by: Wu Jiaxin <jiaxin.wu at intel.com>
> Signed-off-by: Fu Siyuan <siyuan.fu at intel.com>
> Signed-off-by: Wang Fan <fan.wang at intel.com>
> Signed-off-by: Chang Abner <abner.chang at hpe.com>
> Cc: Nickle Wang <nickle.wang at hpe.com>
> Cc: Andrew Fish <afish at apple.com>
> Cc: Laszlo Ersek <lersek at redhat.com>
> Cc: Leif Lindholm <leif at nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> ---
>  RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++++++++++++++++++
>  RedfishPkg/RedfishPkg.dec     | 18 ++++++++++
>  RedfishPkg/RedfishPkg.dsc     | 40 +++++++++++++++++++++
>  3 files changed, 125 insertions(+)
>  create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
>  create mode 100644 RedfishPkg/RedfishPkg.dec
>  create mode 100644 RedfishPkg/RedfishPkg.dsc

based on the diffstat:

Acked-by: Laszlo Ersek <lersek at redhat.com>

However, I suggest resending this series (more precisely, sending a v3).
Here's why:

The patch seems to have been posted "From: changab
<abner.chang at hpe.com>". This will be recorded in the git history, by
git-am. (The mergify bot overwrites the Committer meta-field, but the
Author meta-field remains in place, from git-am -- and that works from
"From:".)

I think "Abner Chang <abner.chang at hpe.com>" looks a whole lot better
than "changab <abner.chang at hpe.com>", in the Author field. So please
rebase this series locally, picking the "edit" action for each patch,
and then re-commit each patch with:

  git commit --amend --author="Abner Chang <abner.chang at hpe.com>"
  git rebase --continue

Additionally, please update the "user.name" knob in your git config.

Sorry for obsessing about this -- I'd really like the git history to
look *nice*.

Thanks
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65785): https://edk2.groups.io/g/devel/message/65785
Mute This Topic: https://groups.io/mt/77210801/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-