[edk2-devel] [Patch] Basetools: Fixed FMMT Linux build break issue

[Bob Feng]

Sorry for confusion. I'll update the patch title, it should have [edk2-staging] prefix.

Thanks,
Bob

-----Original Message-----
From: Philippe Mathieu-Daudé <philmd at redhat.com> 
Sent: Tuesday, October 13, 2020 4:48 PM
To: Feng, Bob C <bob.c.feng at intel.com>; devel at edk2.groups.io
Cc: Yunhua Feng <fengyunhua at byosoft.com.cn>; Liming Gao <gaoliming at byosoft.com.cn>
Subject: Re: [edk2-devel] [Patch] Basetools: Fixed FMMT Linux build break issue

On 10/13/20 10:32 AM, Feng, Bob C wrote:
> Hi Phil,
> 
> Since the FMMT tool is in the edk2-staging repo, branch FceFmmt, the 950333853b5fe2b73a7b5148501458cc97a01481 is in there.

Well this is confusing. Some contributors use the staging/ prefix in their patch subject.

Maybe the contribution guideline could be updated.

> 
> Thanks,
> Bob
> 
> -----Original Message-----
> From: Philippe Mathieu-Daudé <philmd at redhat.com>
> Sent: Tuesday, October 13, 2020 4:02 PM
> To: devel at edk2.groups.io; Feng, Bob C <bob.c.feng at intel.com>
> Cc: Yunhua Feng <fengyunhua at byosoft.com.cn>; Liming Gao 
> <gaoliming at byosoft.com.cn>
> Subject: Re: [edk2-devel] [Patch] Basetools: Fixed FMMT Linux build 
> break issue
> 
> On 10/13/20 9:23 AM, Bob Feng wrote:
>> Fixed the FMMT Linux build issue which was introduced by the commit
>> 950333853b5fe2b73a7b5148501458cc97a01481
> 
> fatal: bad object 950333853b5fe2b73a7b5148501458cc97a01481
> 
>>
>> Signed-off-by: Bob Feng <bob.c.feng at intel.com>
>> Cc: Yunhua Feng <fengyunhua at byosoft.com.cn>
>> Cc: Liming Gao <gaoliming at byosoft.com.cn>
>> ---
>>    .../Source/C/FMMT/FirmwareModuleManagement.c      | 15 ++++-----------
>>    1 file changed, 4 insertions(+), 11 deletions(-)
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66169): https://edk2.groups.io/g/devel/message/66169
Mute This Topic: https://groups.io/mt/77478681/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-