[edk2-devel] CI test on copyright

Bob Feng bob.c.feng at intel.com
Mon Oct 19 01:24:47 UTC 2020


In the ECC, the rule to check Copyright is to see if the Copyright is the first word of a line, and the Copyright should be followed by a (

Liming, for your reference, the code in ECC

## _IsCopyrightLine
# check whether current line is copyright line, the criteria is whether there is case insensitive keyword "Copyright"
# followed by zero or more white space characters followed by a "(" character
#
# @param LineContent:  the line need to be checked
# @return: True if current line is copyright line, False else
#

-Bob

-----Original Message-----
From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of gaoliming
Sent: Monday, October 19, 2020 9:01 AM
To: devel at edk2.groups.io; spbrogan at outlook.com; shenglei.zhang at intel.com; abner.chang at hpe.com
Cc: 'Bret Barkelew' <Bret.Barkelew at microsoft.com>; 'Sean Brogan' <sean.brogan at microsoft.com>
Subject: 回复: [edk2-devel] CI test on copyright

I will check this issue first. 

Thanks
Liming

> -----邮件原件-----
> 发件人: bounce+27952+66349+4905953+8761045 at groups.io
> <bounce+27952+66349+4905953+8761045 at groups.io> 代表 Sean
> 发送时间: 2020年10月17日 12:46
> 收件人: devel at edk2.groups.io; shenglei.zhang at intel.com; 
> abner.chang at hpe.com
> 抄送: Bret Barkelew <Bret.Barkelew at microsoft.com>; Sean Brogan 
> <sean.brogan at microsoft.com>
> 主题: Re: [edk2-devel] CI test on copyright
> 
> ECC stuff was done by Intel. I would defer to them.
> 
> Adding shenglei.zhang at intel.com
> 
> On 10/15/2020 9:21 AM, Abner Chang wrote:
> > Hi Sean and Bret,
> > I got the CI test error which says the first line in file header 
> > section
must
> have the copyright information, however the copyright is there and 
> looks
to
> me fine as below,
> > (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> >
> > [cid:image001.png at 01D6A351.31688460]
> >
> >
> > The interesting part is CI seems happy with below format of 
> > copyright,
and
> this issue only happens on INF file but not on the *.c and *.h.
> > Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
> >
> > Any idea on this?
> > Abner
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 










-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66358): https://edk2.groups.io/g/devel/message/66358
Mute This Topic: https://groups.io/mt/77649850/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list