回复: 回复: [edk2-devel] 回复: 回复: 回复: [PATCH v2 01/11] MdePkg, OvmfPkg: Clean up GHCB field offsets and save area

[gaoliming]

Laszlo:
 I agree Bisectability is important. I want to consider the impact and balance the change. Now, this change will update UefiCpuPkg. I also want to collect the feedback from UefiCpuPkg maintainer: Ray and Eric. 

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+66536+4905953+8761045 at groups.io
> <bounce+27952+66536+4905953+8761045 at groups.io> 代表 Laszlo Ersek
> 发送时间: 2020年10月22日 21:13
> 收件人: gaoliming <gaoliming at byosoft.com.cn>; devel at edk2.groups.io;
> thomas.lendacky at amd.com
> 抄送: 'Brijesh Singh' <brijesh.singh at amd.com>; 'Michael D Kinney'
> <michael.d.kinney at intel.com>; 'Zhiguang Liu' <zhiguang.liu at intel.com>;
> 'Jordan Justen' <jordan.l.justen at intel.com>; 'Ard Biesheuvel'
> <ard.biesheuvel at arm.com>
> 主题: Re: 回复: [edk2-devel] 回复: 回复: 回复: [PATCH v2 01/11] MdePkg,
> OvmfPkg: Clean up GHCB field offsets and save area
> 
> On 10/22/20 03:25, gaoliming wrote:
> > Tom:
> >   For the patch in UefiCpuPkg, this changes the library interface. So, the
> consumer and producer code is required to be changed together. There is no
> good compatible way to do it. I still prefer to separate them for the different
> package. Although the first commit breaks the tree, your patch is the patch
> serial, they will be merged together. Its impact should be small.
> 
> I really disagree here. Bisectability is way more important, in my
> opinion, than avoiding a multi-package patch.
> 
> I agree we should avoid multi-package patches as much as we can -- but
> not more than we can. Bisectability (= keeping the tree buildable at
> every commit) is very important, in my opinion.
> 
> Thanks,
> Laszlo
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66553): https://edk2.groups.io/g/devel/message/66553
Mute This Topic: https://groups.io/mt/77745170/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-