[edk2-devel] [Redfish Discover Header File PATCH] RedfishPkg/Include: EFI Redfish Discover Protocol header file

[Rebecca Cran]

Sorry, you're right - and it was pointed out to me that the leading 
underscore is reserved in C anyway.


-- 
Rebecca Cran


On 10/29/20 5:38 PM, Chang, Abner (HPS SW/FW Technologist) wrote:
> Hi Rebecca,
> We don’t need the leading underscore for the macro as it mentioned in the edk2 C coding standard (section 3.3.2).
>
> Thanks for reviewing this.
> Abner
>
>> -----Original Message-----
>> From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of
>> Rebecca Cran
>> Sent: Friday, October 30, 2020 5:42 AM
>> To: devel at edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>> <abner.chang at hpe.com>
>> Cc: Jiaxin Wu <jiaxin.wu at intel.com>; Siyuan Fu <siyuan.fu at intel.com>; Fan
>> Wang <fan.wang at intel.com>; Jiewen Yao <jiewen.yao at intel.com>; Wang,
>> Nickle (HPS SW) <nickle.wang at hpe.com>
>> Subject: Re: [EXTERNAL] [edk2-devel] [Redfish Discover Header File PATCH]
>> RedfishPkg/Include: EFI Redfish Discover Protocol header file
>>
>> I think the header include guard should have a leading underscore - e.g.
>> _EFI_REDFISH_DISCOVER_PROTOCOL_H_.
>>
>> And it's nice if there's a comment on the #endif to say what it's for.
>>
>>
>> --
>> Rebecca Cran
>>
>>
>> On 10/12/20 10:33 PM, Abner Chang wrote:
>>> diff --git a/RedfishPkg/Include/Protocol/RedfishDiscover.h
>> b/RedfishPkg/Include/Protocol/RedfishDiscover.h
>>> new file mode 100644
>>> index 0000000000..574d7a16a6
>>> --- /dev/null
>>> +++ b/RedfishPkg/Include/Protocol/RedfishDiscover.h
>>> @@ -0,0 +1,198 @@
>>> +/** @file
>>> +  This file defines the EFI Redfish Discover Protocol interface.
>>> +
>>> +  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
>>> +
>>> +  SPDX-License-Identifier: BSD-2-Clause-Patent
>>> +
>>> +**/
>>> +
>>> +#ifndef EFI_REDFISH_DISCOVER_PROTOCOL_H_
>>> +#define EFI_REDFISH_DISCOVER_PROTOCOL_H_
>>> +
>>>
>>
>> 
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66773): https://edk2.groups.io/g/devel/message/66773
Mute This Topic: https://groups.io/mt/77900805/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-