[edk2-devel] [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition
Gao, Zhichao
zhichao.gao at intel.com
Fri Oct 30 01:08:02 UTC 2020
The patch 1-4 are same with V1. If there is no change with previous patches and the patches are already reviewed. You should add the Reviewed-by for the reviewed patches. That would avoid Maintainers/Reviewers to review the patches again. And it is suggested to add the change info in the cover-letter.
Keep my RB for 1-4. I am OK with patch #5: Reviewed-by: Zhichao Gao <zhichao.gao at intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: Rebecca Cran <rebecca at nuviainc.com>
> Sent: Wednesday, October 28, 2020 1:29 AM
> To: devel at edk2.groups.io
> Cc: Rebecca Cran <rebecca at nuviainc.com>; Kinney, Michael D
> <michael.d.kinney at intel.com>; Liming Gao <gaoliming at byosoft.com.cn>; Liu,
> Zhiguang <zhiguang.liu at intel.com>; Ni, Ray <ray.ni at intel.com>; Gao, Zhichao
> <zhichao.gao at intel.com>
> Subject: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0
> ARM64 SoC ID definition
>
> Fix some typos in smbiosview.
>
> Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h and
> smbiosview.
>
> Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield.
>
> Pull request: https://github.com/tianocore/edk2/pull/1052
>
> Rebecca Cran (5):
> ShellPkg: Fix a couple of typos in smbiosview
> ShellPkg: Fix smbiosview string definition name for "boot from CD"
> ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview
> MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
> MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16
>
> MdePkg/Include/IndustryStandard/SmBios.h | 21 ++++++++++---------
> .../SmbiosView/PrintInfo.c | 2 +-
> .../SmbiosView/QueryTable.c | 4 ++++
> .../SmbiosView/SmbiosViewStrings.uni | 4 ++--
> 4 files changed, 18 insertions(+), 13 deletions(-)
>
> --
> 2.26.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66782): https://edk2.groups.io/g/devel/message/66782
Mute This Topic: https://groups.io/mt/77843784/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list