[edk2-devel] [PATCH] SecurityPkg: Initailize variable Status before it is consumed.
Laszlo Ersek
lersek at redhat.com
Tue Sep 1 07:02:32 UTC 2020
On 09/01/20 02:55, Zhiguang Liu wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2945
>
> V2: Move "Status = EFI_SUCCESS;" before the EDKII_TCG_PRE_HASH check.
>
> Cc: Jiewen Yao <jiewen.yao at intel.com>
> Cc: Jian J Wang <jian.j.wang at intel.com>
> Cc: Qi Zhang <qi1.zhang at intel.com>
> Cc: Rahul Kumar <rahul1.kumar at intel.com>
> Cc: Laszlo Ersek <lersek at redhat.com>
> Reviewed-by: Jiewen Yao <jiewen.yao at intel.com>
> Signed-off-by: Zhiguang Liu <zhiguang.liu at intel.com>
> ---
> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> index 0e770f4485..93a8803ff6 100644
> --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> @@ -456,6 +456,7 @@ HashLogExtendEvent (
> if ((Flags & EDKII_TCG_PRE_HASH) != 0 || (Flags & EDKII_TCG_PRE_HASH_LOG_ONLY) != 0) {
> ZeroMem (&DigestList, sizeof(DigestList));
> CopyMem (&DigestList, HashData, sizeof(DigestList));
> + Status = EFI_SUCCESS;
> if ((Flags & EDKII_TCG_PRE_HASH) !=0 ) {
> Status = Tpm2PcrExtend (
> NewEventHdr->PCRIndex,
>
Reviewed-by: Laszlo Ersek <lersek at redhat.com>
I'll let Jiewen or Jian merge this.
Please change the status of TianoCore#2945 to IN_PROGRESS, and link both
versions of this patch into the ticket as well (in a new comment).
Thanks
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#64869): https://edk2.groups.io/g/devel/message/64869
Mute This Topic: https://groups.io/mt/76530112/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list