[edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

[Laszlo Ersek]

Hi Paul,

meta:

On 08/27/20 22:40, Paul wrote:
> In Acpi10.h, EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT is defined as 0x10,
> but should be 0x02 per the ACPI Specification.
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2937
> 
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Cc: Liming Gao <gaoliming at byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu at intel.com>
> Signed-off-by: Paul G <paul.grimes at amd.com>
> ---
>  MdePkg/Include/IndustryStandard/Acpi10.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

please consider setting the "user.name" git config knob to your full
name. We now have:

commit 5ffcbc46908a2037ae3260d3cfcc103e4a6a48c0
Author: Paul <paul.grimes at amd.com>
Date:   Fri Aug 28 04:40:51 2020 +0800

    MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

and I like to be friendly :) but I think the Author field should state,
in general, the full name, not just the first name.


Similary, the Signed-off-by tag at the end of the commit message should
carry the full name too. Please see section "Developer Certificate of
Origin" in "ReadMe.rst":

"""
Signed-off-by: Developer Name developer at example.org

where ``Developer Name`` is the contributor's real name, and the email
address is one the developer is reachable through at the time of
contributing.
"""

It's quite obvious from the email address that "Paul G" stands for Paul
Grimes, but still spell it out.


(These requests are for the future, of course; the present patch has
been merged.)

Thanks!
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64966): https://edk2.groups.io/g/devel/message/64966
Mute This Topic: https://groups.io/mt/76462757/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-