[edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Changed gcc version to be integer

[Samer El-Haj-Mahmoud]

Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>


> -----Original Message-----
> From: Joseph Hemann <joseph.hemann at arm.com>
> Sent: Wednesday, August 26, 2020 5:46 PM
> To: devel at edk2.groups.io
> Cc: G Edhaya Chandran <Edhaya.Chandran at arm.com>; Eric Jin
> <eric.jin at intel.com>; Irene Park <ipark at nvidia.com>; Heinrich Schuchardt
> <xypron.glpk at gmx.de>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud at arm.com>
> Subject: [PATCH v1 1/1] uefi-sct/SctPkg: Changed gcc version to be integer
>
> gcc_version returned by compiler is a string, and needs to be converted to a
> integer before testing
>
> Cc: G Edhaya Chandran <Edhaya.Chandran at arm.com>
> Cc: Eric Jin <eric.jin at intel.com>
> Cc: Irene Park <ipark at nvidia.com>
> Cc: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud at arm.com>
> Signed-off-by: Joseph Hemann <joseph.hemann at arm.com>
> Change-Id: I24f3f52c12660928b58e6f836fdef86890688d26
> ---
>  uefi-sct/SctPkg/build.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh index
> d0c7f16e172c..cad17ccdedc7 100755
> --- a/uefi-sct/SctPkg/build.sh
> +++ b/uefi-sct/SctPkg/build.sh
> @@ -56,8 +56,8 @@ function get_gcc_version  {
>  gcc_version=$($1 -dumpversion)
>
> -    if [ "$gcc_version" -gt "5" ]; then
> -        gcc_version="5"
> +    if [ ${gcc_version%%.*} -gt 5 ]; then
> +        gcc_version=5
>      fi
>
>  case $gcc_version in
> --
> 2.17.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#65009): https://edk2.groups.io/g/devel/message/65009
Mute This Topic: https://groups.io/mt/76439007/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-