[edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]
Guo Dong
guo.dong at intel.com
Wed Sep 16 17:30:23 UTC 2020
Hi Laszlo,
The patchset includes 3 patches, and all of them had been reviewed by package owners.
The patch submitter has a pull request https://github.com/tianocore/edk2/pull/885, I rebased the patch to latest master, and merged it by adding reviewed-by found from emails.
I also make sure it passed all the checks before I put "push" button there. then retrigger a new build with "push" button.
I am not sure what is missing. If there is any other requirements, should they be captured during code review or tool check?
Thanks,
Guo
> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, September 16, 2020 1:57 AM
> To: Dong, Guo <guo.dong at intel.com>
> Cc: devel at edk2.groups.io; marcello.bauer at 9elements.com; Kinney, Michael D
> <michael.d.kinney at intel.com>; Leif Lindholm (Nuvia address)
> <leif at nuviainc.com>; Doran, Mark <mark.doran at intel.com>; Andrew Fish
> <afish at apple.com>; Guptha, Soumya K <soumya.k.guptha at intel.com>
> Subject: [edk2-devel] more development process failure [was: UefiPayloadPkg:
> Runtime MMCONF]
>
> Guo,
>
> On 08/18/20 10:24, Marcello Sylvester Bauer wrote:
> > Support arbitrary platforms with different or even no MMCONF space.
> > Fixes crash on platforms not exposing 256 buses.
> >
> > Tested on:
> > * AMD Stoney Ridge
> >
> > Branch: https://github.com/9elements/edk2-1/tree/UefiPayloadPkg-
> MMCONF
> > PR: https://github.com/tianocore/edk2/pull/885
> >
> > v5:
> > * MdePkg
> > - support variable size MMCONF in all PciExpressLibs
> > - use (UINTX)-1 as return values for invalid Pci addresses
>
> Okay, so we got more of the same development process violations here, as
> I've just reported at <https://edk2.groups.io/g/devel/message/65313>.
>
> See this new pull request:
>
> https://github.com/tianocore/edk2/pull/932/
>
> "No description provided."
>
> You should be embarrassed.
>
> Laszlo
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65337): https://edk2.groups.io/g/devel/message/65337
Mute This Topic: https://groups.io/mt/76883567/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list