[edk2-devel] [PATCH v1 0/7] DynamicTablesPkg: Fix assert ordering and ECC reported issues

Sami Mujawar sami.mujawar at arm.com
Tue Sep 22 14:42:28 UTC 2020


This patch series fixes an assert ordering issue and the following
issues reported by the ECC tool.
  - [9002]  The function headers should follow Doxygen special
            documentation blocks in section 2.3.5 in Comment,
              - <@param [in]> does NOT have [in, out]
              - does NOT have tail **/
  - [1008]  File has invalid Non-ACSII char.
  - [5007]  There should be no initialization of a variable as part of
              its declaration Variable Name.
  - Changes the AML_DEBUG_STR() macro to AML_OPCODE_DEF().
 
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/1423_fix_assert_ordering_v1

Sami Mujawar (7):
  DynamicTablesPkg: Fix order of assert checks
  DynamicTablesPkg: SsdtSerialPortLibArm fix ECC error
  DynamicTablesPkg: AcpiSratLibArm fix ECC error
  DynamicTablesPkg: AmlLib fix ECC errors
  DynamicTablesPkg: AmlLib\AmlDbgPrint fix ECC error
  DynamicTablesPkg: AmlEncoding change debug macro
  DynamicTablesPkg: SsdtSerialPortFixupLib fix ECC errors

 DynamicTablesPkg/DynamicTablesPkg.ci.yaml                                            |   1 +
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c                     |   4 +-
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c |  10 +-
 DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.c                     |  10 +-
 DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.h                     |  40 ++-
 DynamicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.c                             | 304 ++++++++++----------
 DynamicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.h                             |   4 +-
 DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c                          |   4 +-
 DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c              |   2 +-
 DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c                      |   6 +-
 DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c                   |   8 +-
 DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c                      |  16 +-
 DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c                            |  20 +-
 DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataParser.c                |   4 +-
 DynamicTablesPkg/Library/Common/AmlLib/Stream/AmlStream.c                            |   4 +-
 DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c                                |   6 +-
 DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlTree.c                                |   2 +-
 DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c      |  18 +-
 18 files changed, 246 insertions(+), 217 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65452): https://edk2.groups.io/g/devel/message/65452
Mute This Topic: https://groups.io/mt/77014349/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list