[edk2-devel] [Patch] EmulatorPkg: Add CI build for SECURE_BOOT_ENABLE

[Sean]

I think you should add NOOPT target as well.  NOOPT catches more 
compiler issues than debug/release given the change in optimization 
flags and it is used less by developers.

Once you run a build you should also add the badge to the readme.rst 
(https://github.com/tianocore/edk2/blob/master/ReadMe.rst) so that 
status is visible.

and finally the readme should be updated to include details on this 
configuration.
https://github.com/tianocore/edk2/blob/master/EmulatorPkg/PlatformCI/ReadMe.md#supported-configuration-details

Thanks
Sean




On 9/24/2020 5:48 PM, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2979
> 
> Add EmulatorPkg CI builds for SECURE_BOOT_ENABLE=TRUE
> for IA32/X64 and DEBUG/RELEASE.  Label this these as
> FULL builds, so if additional build options are added
> in the future, they can be added to these FULL builds.
> 
> Cc: Jordan Justen <jordan.l.justen at intel.com>
> Cc: Andrew Fish <afish at apple.com>
> Cc: Ray Ni <ray.ni at intel.com>
> Cc: Divneil Rai Wadhawan <divneil.r.wadhawan at intel.com>
> Cc: Sean Brogan <sean.brogan at microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney at intel.com>
> ---
>   .../.azurepipelines/Ubuntu-GCC5.yml           | 29 +++++++++++++++++++
>   .../.azurepipelines/Windows-VS2019.yml        | 29 +++++++++++++++++++
>   2 files changed, 58 insertions(+)
> 
> diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index 12ef8226ff..b5f1d933f4 100644
> --- a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -6,6 +6,7 @@
>   # Toolchain: GCC5
>   #
>   # Copyright (c) Microsoft Corporation.
> +# Copyright (c) 2020, Intel Corporation. All rights reserved.
>   # SPDX-License-Identifier: BSD-2-Clause-Patent
>   ##
>   trigger:
> @@ -65,6 +66,34 @@ jobs:
>               Build.Target: "NOOPT"
>               Run.Flags: $(run_flags)
>               Run: $(should_run)
> +          EmulatorPkg_X64_FULL_DEBUG:
> +            Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> +            Build.Arch: "X64"
> +            Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> +            Build.Target: "DEBUG"
> +            Run.Flags: $(run_flags)
> +            Run: $(should_run)
> +          EmulatorPkg_X64_FULL_RELEASE:
> +            Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> +            Build.Arch: "X64"
> +            Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> +            Build.Target: "RELEASE"
> +            Run.Flags: $(run_flags)
> +            Run: $(should_run)
> +          EmulatorPkg_IA32_FULL_DEBUG:
> +            Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> +            Build.Arch: "IA32"
> +            Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> +            Build.Target: "DEBUG"
> +            Run.Flags: $(run_flags)
> +            Run: $(should_run)
> +          EmulatorPkg_IA32_FULL_RELEASE:
> +            Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> +            Build.Arch: "IA32"
> +            Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> +            Build.Target: "RELEASE"
> +            Run.Flags: $(run_flags)
> +            Run: $(should_run)
>   
>       workspace:
>         clean: all
> diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> index a5baf4b606..5d52d532aa 100644
> --- a/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> +++ b/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> @@ -6,6 +6,7 @@
>   # Toolchain: VS2019
>   #
>   # Copyright (c) Microsoft Corporation.
> +# Copyright (c) 2020, Intel Corporation. All rights reserved.
>   # SPDX-License-Identifier: BSD-2-Clause-Patent
>   ##
>   trigger:
> @@ -66,6 +67,34 @@ jobs:
>               Build.Target: "NOOPT"
>               Run.Flags: $(run_flags)
>               Run: $(should_run)
> +          EmulatorPkg_X64_FULL_DEBUG:
> +            Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> +            Build.Arch: "X64"
> +            Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> +            Build.Target: "DEBUG"
> +            Run.Flags: $(run_flags)
> +            Run: $(should_run)
> +          EmulatorPkg_X64_FULL_RELEASE:
> +            Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> +            Build.Arch: "X64"
> +            Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> +            Build.Target: "RELEASE"
> +            Run.Flags: $(run_flags)
> +            Run: $(should_run)
> +          EmulatorPkg_IA32_FULL_DEBUG:
> +            Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> +            Build.Arch: "IA32"
> +            Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> +            Build.Target: "DEBUG"
> +            Run.Flags: $(run_flags)
> +            Run: $(should_run)
> +          EmulatorPkg_IA32_FULL_RELEASE:
> +            Build.File: "$(package)/PlatformCI/PlatformBuild.py"
> +            Build.Arch: "IA32"
> +            Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=TRUE"
> +            Build.Target: "RELEASE"
> +            Run.Flags: $(run_flags)
> +            Run: $(should_run)
>   
>       workspace:
>         clean: all
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65605): https://edk2.groups.io/g/devel/message/65605
Mute This Topic: https://groups.io/mt/77070643/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-