[edk2-devel] [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset

Maciej Rabeda maciej.rabeda at linux.intel.com
Tue Sep 29 13:46:59 UTC 2020


Reviewed-by: Maciej Rabeda <maciej.rabeda at linux.intel.com>

On 28-Sep-20 08:29, Abner Chang wrote:
> BZ #2909,
> https://bugzilla.tianocore.org/show_bug.cgi?id=2909
>
> When Http->Configure() is invoked with HttpConfigData set to
> NULL to reset the EFI HTTP instance, TLS child instance is
> destroyed but HttpInstance->TlsChildHandle is not set to
> NULL. After reconfiguring HTTP through Http->Configure()
> and sending the HTTP request to HTTPS URL, TLS child
> instance is not recreated because
> HttpInstance->TlsChildHandle is not NULL.
>
> Signed-off-by: Abner Chang <abner.chang at hpe.com>
>
> Cc: Maciej Rabeda <maciej.rabeda at linux.intel.com>
> Cc: Wu Jiaxin <jiaxin.wu at intel.com>
> Cc: Fu Siyuan <siyuan.fu at intel.com>
> Cc: Nickle Wang <nickle.wang at hpe.com>
> ---
>   NetworkPkg/HttpDxe/HttpProto.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c
> index 3c7c6ff9f0c..afc7db5a726 100644
> --- a/NetworkPkg/HttpDxe/HttpProto.c
> +++ b/NetworkPkg/HttpDxe/HttpProto.c
> @@ -873,6 +873,7 @@ HttpCleanProtocol (
>       // Destroy the TLS instance.
>       //
>       HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance->TlsChildHandle);
> +    HttpInstance->TlsChildHandle = NULL;
>     }
>   
>     if (HttpInstance->Tcp4ChildHandle != NULL) {



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65727): https://edk2.groups.io/g/devel/message/65727
Mute This Topic: https://groups.io/mt/77169386/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list