[edk2-devel] [PATCH 24/24] [hack] turn off -Werror

[Gerd Hoffmann]

On Fri, Dec 03, 2021 at 06:38:52PM +0000, Kinney, Michael D wrote:
> Hi Pedro,
> 
> If there are specific issues with specific submodules, I would prefer
> that we disable only the specific subset of warnings that are
> triggered by that one project.  Disabling all warnings as errors may
> hide way too much.
> 
> The INF file for building a lib that uses submodule content can append
> CC_FLAGS with specific warning disable.  We did this approach for the
> Python3 work in edk2-libc.  I think we ran into issue around MIN()
> macro as well, but I can’t recall exactly how we fixed it.

There are a bunch of these -Wno-error=<something> in
CryptoPkg/Library/OpensslLib/OpensslLib*.inf already.

> > workaround for this:
> > CryptoPkg/Library/OpensslLib/openssl/providers/implementations/kdfs/kbkdf.c:49: warning: "MIN" redefined

Couldn't figure whenever there is a switch to turn off this one
specifically.  Newer gcc typically prints which -W<name> enables the
warning printed.  Not sure why this didn't happen here, maybe because
it is cpp throwing the warning here.  The cpp man-page likewise doesn't
help much :(

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84378): https://edk2.groups.io/g/devel/message/84378
Mute This Topic: https://groups.io/mt/87479991/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-