[edk2-devel] [PATCH v3 0/7] Support ACPI 6.4 PPTT changes

Chris Jones christopher.jones at arm.com
Wed Dec 8 16:06:23 UTC 2021


Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)

This patch series updates the Acpiview PPTT parser and DynamicTablesPkg
PPTT generator to support ACPI 6.4. This consists of two main changes:
 - The addition of the 'Cache ID' field.
 - The removal of the PPTT ID (type 2) structure.

In addition add two 'Cache ID' defines and remove the type 2 PPTT
structure from Acpi64.h as these changes were missing when Acpi64.h was
introduced.

Changes since v2:
1. Added mantis ID for PPTT type 2 structure removal on relevant commit
   messages. No change to code.
2. Applied uncrustify to all patches. No other changes to code.

Changes since v1:
1. Patch 3/7 ShellPkg:
    - Changed PPTT ID error message to say "removed" instead of "deprecated".
2. Patch 4/7 ShellPkg:
    - Fixed a bug where 'CacheFlags' and 'CacheId' were only set after the
      validation function had finished. Instead set them inside the
      validation function using the first 'Ptr' parameter.
3. Patch 7/7 DynamicTablesPkg:
    - Make IsCacheIdUnique() return BOOLEAN instead of EFI_STATUS.
    - Added a missing space to the definition of 'IsCacheIdUnique'.

The changes can be seen at: https://github.com/chris-jones-arm/edk2/tree/1632_64_acpi_cache_id_v3


Chris Jones (7):
  MdePkg: Add missing Cache ID (in)valid define
  MdePkg: Remove PPTT ID type structure
  ShellPkg: Update Acpiview PPTT parser to ACPI 6.4
  ShellPkg: Add Cache ID to PPTT parser
  DynamicTablesPkg: Remove PPTT ID structure from ACPI 6.4 generator
  DynamicTablesPkg: Update PPTT generator to ACPI 6.4
  DynamicTablesPkg: Add CacheId to PPTT generator

 .../Include/ArmNameSpaceObjects.h             |  27 +-
 .../Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c   | 296 +++++++-----------
 .../Acpi/Arm/AcpiPpttLibArm/PpttGenerator.h   |   4 -
 MdePkg/Include/IndustryStandard/Acpi64.h      |  18 +-
 .../Parsers/Pptt/PpttParser.c                 | 214 +++++++++----
 .../UefiShellAcpiViewCommandLib.c             |   2 +-
 6 files changed, 272 insertions(+), 289 deletions(-)

-- 
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84513): https://edk2.groups.io/g/devel/message/84513
Mute This Topic: https://groups.io/mt/87591332/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list