[edk2-devel] [PATCH v4 0/8] Create a SSDT PCIe generator

Sami Mujawar sami.mujawar at arm.com
Mon Dec 13 12:24:27 UTC 2021


Hi Pierre,

Thank you for this patch series.

This series looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>

Regards,

Sami Mujawar


On 09/12/2021 09:24 AM, Pierre.Gondois at arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois at arm.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3682
>
> As part of the DynamicTablesPkg, add a generator creating a
> SSDT table describing a PCIe bus.
> This patch-set also adds new functions to generate AML bytecode
> in the AmlLib.
>
> The changes can be seen at: https://github.com/PierreARM/edk2/tree/1781_Create_ssdt_pcie_generator_v3
>
> v4:
> - Run uncrustify and apply the required formatting. [Pierre]
> - No other change with v3. [Pierre]
> v3:
> - Use ASSERT_EFI_ERROR when possible. [Sami]
> - Fix typos and add comments. [Pierre]
> - Add new patch "DynamicTablesPkg: Fix multiple objects parsing".
>    [Pierre]
> v2:
> The following patches were modified:
> - DynamicTablesPkg: AML Code generation for memory ranges
> - DynamicTablesPkg: SSDT Pci express generator
>
> Pierre Gondois (8):
>    DynamicTablesPkg: AML Code generation for memory ranges
>    DynamicTablesPkg: AML Code generation to create a named Package()
>    DynamicTablesPkg: AML Code generation to create a named
>      ResourceTemplate()
>    DynamicTablesPkg: AML Code generation to add _PRT entries
>    DynamicTablesPkg: Add AmlAttachNode()
>    DynamicTablesPkg: Add Pci related objects
>    DynamicTablesPkg: SSDT Pci express generator
>    DynamicTablesPkg: Fix multiple objects parsing
>
>   DynamicTablesPkg/DynamicTables.dsc.inc        |    2 +
>   DynamicTablesPkg/Include/AcpiTableGenerator.h |    5 +
>   .../Include/ArmNameSpaceObjects.h             |   86 +-
>   .../Include/Library/AmlLib/AmlLib.h           |  413 +++++
>   .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c    | 1460 +++++++++++++++++
>   .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.h    |  138 ++
>   .../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf |   32 +
>   .../SsdtPcieOscTemplate.asl                   |   80 +
>   .../Library/Common/AmlLib/Api/AmlApi.c        |   36 +
>   .../Common/AmlLib/CodeGen/AmlCodeGen.c        |  326 ++++
>   .../AmlLib/CodeGen/AmlResourceDataCodeGen.c   |  951 +++++++++++
>   .../ConfigurationManagerObjectParser.c        |   48 +-
>   12 files changed, 3568 insertions(+), 9 deletions(-)
>   create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
>   create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.h
>   create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf
>   create mode 100644 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieOscTemplate.asl
>
> --
> 2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84702): https://edk2.groups.io/g/devel/message/84702
Mute This Topic: https://groups.io/mt/87608847/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list