[edk2-devel] [PATCH 1/3] ArmPkg/SmbiosMiscDxe: Remove duplicate HII string definition

[Sami Mujawar]

Hi Nhi,

Thank you for this patch.
This change looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>

Regards,

Sami Mujawar

On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote:
> This patch removes duplicate HII string definition in the
> MiscSystemManufacturer.uni.
>
> Cc: Leif Lindholm <leif at nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
> Cc: Rebecca Cran <rebecca at nuviainc.com>
> Signed-off-by: Nhi Pham <nhi at os.amperecomputing.com>
> ---
>   ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni
> index 8038f0e4b0bf..2b3b19cab2ea 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni
> @@ -13,7 +13,6 @@
>   
>   #string STR_MISC_SYSTEM_MANUFACTURER   #language en-US  "Not Specified"
>   #string STR_MISC_SYSTEM_PRODUCT_NAME   #language en-US  "Not Specified"
> -#string STR_MISC_SYSTEM_PRODUCT_NAME   #language en-US  "Not Specified"
>   #string STR_MISC_SYSTEM_VERSION        #language en-US  "Not Specified"
>   #string STR_MISC_SYSTEM_SERIAL_NUMBER  #language en-US  "Not Specified"
>   #string STR_MISC_SYSTEM_SKU_NUMBER     #language en-US  "Not Specified"



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84910): https://edk2.groups.io/g/devel/message/84910
Mute This Topic: https://groups.io/mt/87420726/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-