[edk2-devel] [PATCH 0/3] ArmPkg/SMBIOS: Update HII string settings for SMBIOS

[Nhi Pham via groups.io]

Hi Sami,

On 16/12/2021 00:06, Sami Mujawar wrote:
> Hi Nhi,
>
> These patches do not cleanly apply. I guess you would need to run 
> uncrustify for these patches.
>
> Can you check, please?

Sure, will fix all coding style issues found by uncrustify and change to 
use FixedPcdGetPtr() instead of PcdGetPtr() as your suggestion in the 
PATCH 3/3.

Thanks,

Nhi

>
> Regards,
>
> Sami Mujawar
>
>
> On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote:
>> This patchset leverages the OemUpdateSmbiosInfo API functions from
>> OemMiscLib for updating some HII string fields in the SMBIOS Type 1/2/4
>> because they may be updated dynamically during UEFI booting with the
>> data being passed from the pre-UEFI firmware.
>>
>> Cc: Leif Lindholm <leif at nuviainc.com>
>> Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
>> Cc: Rebecca Cran <rebecca at nuviainc.com>
>> Signed-off-by: Nhi Pham <nhi at os.amperecomputing.com>
>>
>> Nhi Pham (3):
>>    ArmPkg/SmbiosMiscDxe: Remove duplicate HII string definition
>>    ArmPkg/SmbiosMiscDxe: Get full SMBIOS strings from OemMiscLib
>>    ArmPkg/ProcessorSubClassDxe: Get serial and part number from
>>      OemMiscLib
>>
>>   ArmPkg/Include/Library/OemMiscLib.h               |  5 +++++
>>   .../ProcessorSubClassDxe/ProcessorSubClass.c      | 14 ++++++++++++--
>>   .../Type01/MiscSystemManufacturerFunction.c       | 10 ++++++++++
>>   .../Type02/MiscBaseBoardManufacturerFunction.c    | 15 +++++++++++++++
>>   .../Type01/MiscSystemManufacturer.uni             |  1 -
>>   5 files changed, 42 insertions(+), 3 deletions(-)
>>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84954): https://edk2.groups.io/g/devel/message/84954
Mute This Topic: https://groups.io/mt/87420725/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-