[edk2-devel] [PATCH 1/1] UsbBusDxe: fix NOOPT build error

[Wu, Hao A]

Pushed via:
PR - https://github.com/tianocore/edk2/pull/2347
Commit - https://github.com/tianocore/edk2/commit/ae8272ef787d80950803c521a13a308651bdc62e

Best Regards,
Hao Wu

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Wu, Hao
> A
> Sent: Tuesday, December 21, 2021 4:24 PM
> To: Gerd Hoffmann <kraxel at redhat.com>; devel at edk2.groups.io
> Cc: Philippe Mathieu-Daudé <philmd at redhat.com>; Wang, Jian J
> <jian.j.wang at intel.com>; Pawel Polawski <ppolawsk at redhat.com>; Ni, Ray
> <ray.ni at intel.com>; Gao, Liming <gaoliming at byosoft.com.cn>
> Subject: Re: [edk2-devel] [PATCH 1/1] UsbBusDxe: fix NOOPT build error
> 
> > -----Original Message-----
> > From: Gerd Hoffmann <kraxel at redhat.com>
> > Sent: Monday, December 20, 2021 10:33 PM
> > To: devel at edk2.groups.io
> > Cc: Wu, Hao A <hao.a.wu at intel.com>; Philippe Mathieu-Daudé
> > <philmd at redhat.com>; Wang, Jian J <jian.j.wang at intel.com>; Pawel
> > Polawski <ppolawsk at redhat.com>; Ni, Ray <ray.ni at intel.com>; Gao,
> Liming
> > <gaoliming at byosoft.com.cn>; Gerd Hoffmann <kraxel at redhat.com>
> > Subject: [PATCH 1/1] UsbBusDxe: fix NOOPT build error
> 
> 
> Reviewed-by: Hao A Wu <hao.a.wu at intel.com>
> Will tweak the subject to "MdeModulePkg/UsbBusDxe: fix NOOPT build
> error" before merging. If concerns, please help to raise.
> 
> Best Regards,
> Hao Wu
> 
> 
> >
> > gcc-11 (fedora 35):
> >
> >
> /home/kraxel/projects/edk2/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus
> > .c: In function ‘UsbIoBulkTransfer’:
> >
> /home/kraxel/projects/edk2/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus
> > .c:277:12: error: ‘UsbHcBulkTransfer’ accessing 80 bytes in a region of size 8
> [-
> > Werror=stringop-overflow=]
> >
> > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
> > ---
> >  MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h | 2 +-
> > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h
> > b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h
> > index 04cf36d3c860..d93370a6c21e 100644
> > --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h
> > +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h
> > @@ -148,7 +148,7 @@ UsbHcBulkTransfer (
> >    IN  UINT8                               DevSpeed,
> >    IN  UINTN                               MaxPacket,
> >    IN  UINT8                               BufferNum,
> > -  IN  OUT VOID                            *Data[EFI_USB_MAX_BULK_BUFFER_NUM],
> > +  IN  OUT VOID                            *Data[],
> >    IN  OUT UINTN                           *DataLength,
> >    IN  OUT UINT8                           *DataToggle,
> >    IN  UINTN                               TimeOut,
> > diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c
> > b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c
> > index 12d08c0b740f..740e7babb0ca 100644
> > --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c
> > +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c
> > @@ -267,7 +267,7 @@ UsbHcBulkTransfer (
> >    IN  UINT8                               DevSpeed,
> >    IN  UINTN                               MaxPacket,
> >    IN  UINT8                               BufferNum,
> > -  IN  OUT VOID                            *Data[EFI_USB_MAX_BULK_BUFFER_NUM],
> > +  IN  OUT VOID                            *Data[],
> >    IN  OUT UINTN                           *DataLength,
> >    IN  OUT UINT8                           *DataToggle,
> >    IN  UINTN                               TimeOut,
> > --
> > 2.33.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85184): https://edk2.groups.io/g/devel/message/85184
Mute This Topic: https://groups.io/mt/87857128/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-