[edk2-devel] [PATCH 1/1] ArmPkg: Fix ARM ProcessorSubClassDxe build

[Leif Lindholm]

On Wed, Feb 10, 2021 at 08:04:57 -0700, Rebecca Cran wrote:
> The ARM ProcessorSubClassDxe build was broken due to changes in the
> SmbiosProcessor API and an unused variable.
> 
> Signed-off-by: Rebecca Cran <rebecca at nuviainc.com>

Reviewed-by: Leif Lindholm <leif at nuviainc.com>
Pushed as c615265b366d.

Thanks!

> ---
>  ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c
> index 0be4403c765f..c78bd41a7e06 100644
> --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c
> +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c
> @@ -22,7 +22,7 @@
>      @return The cache size.
>  **/
>  UINT64
> -ArmGetCacheSize (
> +SmbiosProcessorGetCacheSize (
>    IN UINT8   CacheLevel,
>    IN BOOLEAN DataCache,
>    IN BOOLEAN UnifiedCache
> @@ -66,14 +66,13 @@ ArmGetCacheSize (
>      @return The cache associativity.
>  **/
>  UINT32
> -ArmGetCacheAssociativity (
> +SmbiosProcessorGetCacheAssociativity (
>    IN UINT8   CacheLevel,
>    IN BOOLEAN DataCache,
>    IN BOOLEAN UnifiedCache
>    )
>  {
>    CCSIDR_DATA  Ccsidr;
> -  CCSIDR2_DATA Ccsidr2;
>    CSSELR_DATA  Csselr;
>    BOOLEAN      CcidxSupported;
>    UINT32       Associativity;
> @@ -88,7 +87,6 @@ ArmGetCacheAssociativity (
>    CcidxSupported = ArmHasCcidx ();
>  
>    if (CcidxSupported) {
> -    Ccsidr2.Data = ReadCCSIDR2 (Csselr.Data);
>      Associativity = Ccsidr.BitsCcidxAA32.Associativity + 1;
>    } else {
>      Associativity = Ccsidr.BitsNonCcidx.Associativity + 1;
> -- 
> 2.26.2
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71586): https://edk2.groups.io/g/devel/message/71586
Mute This Topic: https://groups.io/mt/80533578/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-