回复: [edk2-devel] [PATCH - resend] MdeModulePkg/BootLogoLib: Center logo 38.2% from top of screen

[gaoliming]

Patrick:
  I am OK for this extension to meet with Microsoft recommendation. This
change is a new feature. Can you submit one BZ
(https://bugzilla.tianocore.org/) for it?  

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+71716+4905953+8761045 at groups.io
> <bounce+27952+71716+4905953+8761045 at groups.io> 代表 Patrick
> Rudolph
> 发送时间: 2021年2月17日 18:11
> 收件人: devel at edk2.groups.io
> 抄送: tcrawford at system76.com; jian.j.wang at intel.com;
> hao.a.wu at intel.com; zhichao.gao at intel.com; ray.ni at intel.com
> 主题: [edk2-devel] [PATCH - resend] MdeModulePkg/BootLogoLib: Center
> logo 38.2% from top of screen
> 
> From: Tim Crawford <tcrawford at system76.com>
> 
> Use Microsoft's recommended positioning [1] for the boot logo.
> 
> > We recommend that the logo is placed with its center at 38.2% from the
> > screen's top edge. This positioning is based on the golden ratio's
> > visual aesthetics and matches the Windows 10 design proportions.
> 
> [1]:
> https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-s
> creen-components#position-the-logo-during-post
> 
> Based on Tim Crawford <tcrawford at system76.com> initial commit.
> 
> Signed-off-by: Patrick Rudolph <patrick.rudolph at 9elements.com>
> ---
>  MdeModulePkg/Include/Protocol/PlatformLogo.h   | 3 ++-
>  MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 4 ++++
>  MdeModulePkg/Logo/Logo.c                       | 2 +-
>  3 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h
> b/MdeModulePkg/Include/Protocol/PlatformLogo.h
> index 55c9e08696..21a4c79e1d 100644
> --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h
> +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h
> @@ -29,7 +29,8 @@ typedef enum {
>    EdkiiPlatformLogoDisplayAttributeCenterBottom,
> 
>    EdkiiPlatformLogoDisplayAttributeLeftBottom,
> 
>    EdkiiPlatformLogoDisplayAttributeCenterLeft,
> 
> -  EdkiiPlatformLogoDisplayAttributeCenter
> 
> +  EdkiiPlatformLogoDisplayAttributeCenter,
> 
> +  EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended
> 
>  } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;
> 
> 
> 
>  /**
> 
> diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> index 134660f28d..d40c65b59f 100644
> --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> @@ -173,6 +173,10 @@ BootLogoEnableLogo (
>        DestX = 0;
> 
>        DestY = (SizeOfY - Image.Height) / 2;
> 
>        break;
> 
> +    case EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended:
> 
> +      DestX = (SizeOfX - Image.Width) / 2;
> 
> +      DestY = (SizeOfY * 382) / 1000 - Image.Height / 2;
> 
> +      break;
> 
>      case EdkiiPlatformLogoDisplayAttributeCenter:
> 
>        DestX = (SizeOfX - Image.Width) / 2;
> 
>        DestY = (SizeOfY - Image.Height) / 2;
> 
> diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c
> index c647253ecd..131a1b456a 100644
> --- a/MdeModulePkg/Logo/Logo.c
> +++ b/MdeModulePkg/Logo/Logo.c
> @@ -26,7 +26,7 @@ EFI_HII_HANDLE            mHiiHandle;
>  LOGO_ENTRY                mLogos[] = {
> 
>    {
> 
>      IMAGE_TOKEN (IMG_LOGO),
> 
> -    EdkiiPlatformLogoDisplayAttributeCenter,
> 
> +    EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended,
> 
>      0,
> 
>      0
> 
>    }
> 
> --
> 2.26.2
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#71716): https://edk2.groups.io/g/devel/message/71716
> Mute This Topic: https://groups.io/mt/80700289/4905953
> Group Owner: devel+owner at edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming at byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71769): https://edk2.groups.io/g/devel/message/71769
Mute This Topic: https://groups.io/mt/80722040/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-