[edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder

[Li, Walon]

Hi Liming,

As edk2 design, any new boot options should be put at the end of BootOrder because these are NEW . That means system should "append" BootOrder instead of override original order.
For example, if system has three boot options currently - Boot0001, Boot0002, Boot0003 and then one new option - Boot0000 will be added. The order should become Boot0001,Boot0002,Boot0003,Boot0000. However, in this case, BootmanagerMenu doesn't follow this rule. We set "zero" priority so system would put BootManagerMenu boot option at start.
This case is a corner case because the symptom only be gotten when user delete BootManagerMenu on OS or EFI shell. But it's a possible case. For keeping behavior consistent, we should keep BootManagerMenu option behavior as same as others boot option.

Thanks
Walon

-----Original Message-----
From: gaoliming <gaoliming at byosoft.com.cn> 
Sent: Friday, February 19, 2021 8:59 AM
To: devel at edk2.groups.io; Li, Walon <walon.li at hpe.com>
Cc: Wang, Sunny (HPS SW) <sunnywang at hpe.com>; lersek at redhat.com; ray.ni at intel.com; hao.a.wu at intel.com
Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder

Walon:
  Can you specify the detail reason why BootManagerMenu should be placed at end of BootOrder?

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+71766+4905953+8761045 at groups.io
> <bounce+27952+71766+4905953+8761045 at groups.io> 代表 Li, Walon
> 发送时间: 2021年2月18日 11:26
> 收件人: devel at edk2.groups.io
> 抄送: walon.li at hpe.com; sunnywang at hpe.com; lersek at redhat.com; 
> ray.ni at intel.com; hao.a.wu at intel.com
> 主题: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Put BootMenu 
> at the end of BootOrder
> 
> REF:INVALID URI REMOVED
> ocore.org_show-5Fbug.cgi-3Fid-3D3135&d=DwIFbw&c=C5b8zRQO1miGmBeVZ2LFWg
> &r=nGx4G_nX3rQG_ai3uSb52w&m=4xka-z98KYmCRK888F4f_O1i7tKha1xqkOolDMIoMN
> w&s=G7KN5FPIan9u09Esxr73N0cT6RHiEP7pdQQqikPiss4&e=
> 
> When Boot Menu does not exist in the BootOrder, 
> BmRegisterBootManagerMenu will create one into list. However, it 
> should be put at the "end" of BootOrder instead of "start" of 
> BootOrder. Replace 0 by -1 to adjust order of load options.
> 
> Signed-off-by: Walon Li <walon.li at hpe.com>
> ---
>  MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> index aff620ad52..26d1fb0ea0 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> @@ -2505,7 +2505,7 @@ BmRegisterBootManagerMenu (
>      EfiBootManagerFreeLoadOptions (BootOptions, BootOptionCount);
> 
>      );
> 
> 
> 
> -  return EfiBootManagerAddLoadOptionVariable (BootOption, 0);
> 
> +  return EfiBootManagerAddLoadOptionVariable (BootOption, (UINTN) 
> + -1));
> 
>  }
> 
> 
> 
>  /**
> 
> --
> 2.23.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#71766): 
> INVALID URI REMOVED
> devel_message_71766&d=DwIFbw&c=C5b8zRQO1miGmBeVZ2LFWg&r=nGx4G_nX3rQG_a
> i3uSb52w&m=4xka-z98KYmCRK888F4f_O1i7tKha1xqkOolDMIoMNw&s=FNeonYnzA5fhg
> h2S6hfP4kY5-gdgPq0eocZbLoguHso&e= Mute This Topic: 
> INVALID URI REMOVED
> 1971_4905953&d=DwIFbw&c=C5b8zRQO1miGmBeVZ2LFWg&r=nGx4G_nX3rQG_ai3uSb52
> w&m=4xka-z98KYmCRK888F4f_O1i7tKha1xqkOolDMIoMNw&s=PHg6v0w7mvUp-SA38Cx9
> dzS9IaedUWvbERQszTLJ3w0&e= Group Owner: devel+owner at edk2.groups.io
> Unsubscribe: 
> INVALID URI REMOVED
> devel_unsub&d=DwIFbw&c=C5b8zRQO1miGmBeVZ2LFWg&r=nGx4G_nX3rQG_ai3uSb52w
> &m=4xka-z98KYmCRK888F4f_O1i7tKha1xqkOolDMIoMNw&s=wDph98KE_DgEz55q-XSWy
> -RmRDLGolPPOyZFgp01r0Y&e=
> [gaoliming at byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71796): https://edk2.groups.io/g/devel/message/71796
Mute This Topic: https://groups.io/mt/80746278/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-