[edk2-devel] [PATCH v7 01/10] OvmfPkg/CpuHotplugSmm: refactor hotplug logic

[Laszlo Ersek]

On 02/19/21 10:04, Ankur Arora wrote:
> Refactor CpuHotplugMmi() to pull out the CPU hotplug logic into
> ProcessHotAddedCpus(). This is in preparation for supporting CPU
> hot-unplug.
> 
> Cc: Laszlo Ersek <lersek at redhat.com>
> Cc: Jordan Justen <jordan.l.justen at intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel at arm.com>
> Cc: Igor Mammedov <imammedo at redhat.com>
> Cc: Boris Ostrovsky <boris.ostrovsky at oracle.com>
> Cc: Aaron Young <aaron.young at oracle.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3132
> Signed-off-by: Ankur Arora <ankur.a.arora at oracle.com>
> Reviewed-by: Laszlo Ersek <lersek at redhat.com>
> ---
> 
> Notes:
>     Addresses these review comments from v6:
>      (1) s/EFI_ERROR(/EFI_ERROR (/
>      (2) Remove the empty line in the comment block above
>       ProcessHotAddedCpus().
>      () Nest the EFI_ERROR handling inside the (PluggedCount > 0) clause.
> 
>  OvmfPkg/CpuHotplugSmm/CpuHotplug.c | 210 ++++++++++++++++++++++---------------
>  1 file changed, 126 insertions(+), 84 deletions(-)

LGTM, thanks
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71938): https://edk2.groups.io/g/devel/message/71938
Mute This Topic: https://groups.io/mt/80751393/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-