[edk2-devel] [PATCH] MdeModulePkg: Initialize local variable value before they are used

[Wu, Hao A]

> -----Original Message-----
> From: Liming Gao <gaoliming at byosoft.com.cn>
> Sent: Tuesday, March 9, 2021 9:24 AM
> To: devel at edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang at intel.com>; Wu, Hao A <hao.a.wu at intel.com>
> Subject: [PATCH] MdeModulePkg: Initialize local variable value before they are
> used
> 
> This change is to fix the compiler error on GCC49 release build.


Thanks Liming. The patch looks good to me:
Reviewed-by: Hao A Wu <hao.a.wu at intel.com>

I have one question that I think both the reports are false positives.
Do you think it will be better to add this information in the commit message?

Best Regards,
Hao Wu


> 
> Cc: Jian J Wang <jian.j.wang at intel.com>
> Cc: Hao A Wu <hao.a.wu at intel.com>
> Signed-off-by: Liming Gao <gaoliming at byosoft.com.cn>
> ---
>  MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c                 | 1 +
>  .../Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c    | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
> b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
> index e99a812a44..0779f94f9e 100644
> --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
> +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
> @@ -1122,6 +1122,7 @@ AhciDmaTransfer (
> 
>    Map   = NULL;
>    PciIo = Instance->PciIo;
> +  Status = EFI_SUCCESS;
> 
>    if (PciIo == NULL) {
>      return EFI_INVALID_PARAMETER;
> diff --git
> a/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c
> b/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c
> index 0c9299c8b0..7822cbf4bb 100644
> ---
> a/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c
> +++
> b/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c
> @@ -117,6 +117,7 @@ CreateBasicVariablePolicy (
> 
>    // Now we've gotta determine the total size of the buffer required for
>    // the VariablePolicy structure.
> +  NameSize  = 0;
>    TotalSize = sizeof( VARIABLE_POLICY_ENTRY );
>    if (Name != NULL) {
>      NameSize = StrnSizeS( Name, MAX_UINT16 );
> --
> 2.27.0.windows.1
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72556): https://edk2.groups.io/g/devel/message/72556
Mute This Topic: https://groups.io/mt/81191206/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-