回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance

gaoliming gaoliming at byosoft.com.cn
Wed Mar 17 03:04:35 UTC 2021


Ard and Dandan:

> -----邮件原件-----
> 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 Ard
> Biesheuvel
> 发送时间: 2021年3月16日 23:01
> 收件人: devel at edk2.groups.io; dandan.bi at intel.com; Laszlo Ersek
> <lersek at redhat.com>; Andrew Fish <afish at apple.com>
> 抄送: Leif Lindholm <leif at nuviainc.com>; Michael D Kinney
> <michael.d.kinney at intel.com>; Liming Gao <gaoliming at byosoft.com.cn>
> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume
> RegisterFilterLibNull instance
> 
> On Tue, 16 Mar 2021 at 15:56, Dandan Bi <dandan.bi at intel.com> wrote:
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
> > RFC: https://edk2.groups.io/g/devel/message/72530
> >
> >
> > Add RegisterFilterLibNull in dsc files in edk2-platforms repo,
> > which will be consumed by IoLib and BaseLib.
> >
> > This is the following update in edk2-platforms repo for the change in edk2,
> > which will add RegisterFilterLib dependency for IoLib and BaseLib to
> filter/trace
> > port IO/MMIO/MSR access.
> > https://edk2.groups.io/g/devel/message/72754
> >
> > Cc: Leif Lindholm <leif at nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney at intel.com>
> > Cc: Liming Gao <gaoliming at byosoft.com.cn>
> >
> 
> It is a bit disappointing that we have to update every platform in
> existence again to apply a change to a core module.
> 

I suggest to add MdePkg.dsc.inc file to include the default library instance, 
and update all Platform DSC to include it. Then, for the future change, no change is required for platform DSC. 

Because this patch set updates every platform DSC, I suggest to introduce MdePkg.dsc.inc file in this patch set. 

Thanks
Liming
> Is there really not a better way to provide a 'default' resolution for
> a library class? Maybe a change to the .DEC format, so that the file
> which defines the library class can provide a resolution that is used
> if none is provided by the .DSC file?
> 
> 
> 
> > Dandan Bi (35):
> >   Drivers/ASIX: Consume RegisterFilterLibNull instance
> >   Drivers/DisplayLink: Consume RegisterFilterLibNull instance
> >   Drivers/OptionRomPkg: Consume RegisterFilterLibNull instance
> >   Features/Debugging: Consume RegisterFilterLibNull instance
> >   Features/Network: Consume RegisterFilterLibNull instance
> >   Features/OutOfBandManagement: Consume RegisterFilterLibNull
> instance
> >   Features/PowerManagement: Consume RegisterFilterLibNull instance
> >   Features/SystemInformation: Consume RegisterFilterLibNull instance
> >   Features/UserInterface: Consume RegisterFilterLibNull instance
> >   Platform/AMD: Consume RegisterFilterLibNull instance
> >   Platform/ARM: Consume RegisterFilterLibNull instance
> >   Platform/BeagleBoard: Consume RegisterFilterLibNull instance
> >   Platform/BoardModulePkg: Consume RegisterFilterLibNull instance
> >   Platform/MinPlatformPkg: Consume RegisterFilterLibNull instance
> >   Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull instance
> >   Platform/Vlv2TbltDevicePkg: Consume RegisterFilterLibNull instance
> >   Platform/LeMaker: Consume RegisterFilterLibNull instance
> >   Platform/Qemu: Consume RegisterFilterLibNull instance
> >   Platform/RaspberryPi: Consume RegisterFilterLibNull instance
> >   Platform/RISC-V: Consume RegisterFilterLibNull instance
> >   Platform/SiFive: Consume RegisterFilterLibNull instance
> >   Platform/Socionext: Consume RegisterFilterLibNull instance
> >   Platform/SoftIron: Consume RegisterFilterLibNull instance
> >   Silicon/Hisilicon: Consume RegisterFilterLibNull instance
> >   Silicon/CoffeelakeSiliconPkg: Consume RegisterFilterLibNull instance
> >   Silicon/IntelSiliconPkg: Consume RegisterFilterLibNull instance
> >   Silicon/KabylakeSiliconPkg: Consume RegisterFilterLibNull instance
> >   Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance
> >   Silicon/TigerlakeSiliconPkg: Consume RegisterFilterLibNull instance
> >   Silicon/Marvell: Consume RegisterFilterLibNull instance
> >   Silicon/NXP: Consume RegisterFilterLibNull instance
> >   Silicon/Openmoko: Consume RegisterFilterLibNull instance
> >   Silicon/RISC_V: Consume RegisterFilterLibNull instance
> >   Silicon/Synopsys/DesignWare: Consume RegisterFilterLibNull instance
> >   Silicon/TexasInstruments: Consume RegisterFilterLibNull instance
> >
> >  Drivers/ASIX/Asix.dsc
> | 1 +
> >  Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc          | 1 +
> >  Drivers/OptionRomPkg/OptionRomPkg.dsc
> | 3 ++-
> >  .../Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc | 3
> ++-
> >  .../Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc | 3
> ++-
> >  .../PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc   | 3
> ++-
> >  .../Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc | 3
> ++-
> >  .../Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc | 3
> ++-
> >  .../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 3
> ++-
> >  .../OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc | 3
> ++-
> >  .../Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc   | 3
> ++-
> >  .../SmbiosFeaturePkg/Include/SmbiosFeature.dsc                 | 3
> ++-
> >  .../Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 3 ++-
> >  .../UserAuthFeaturePkg/Include/UserAuthFeature.dsc             | 3
> ++-
> >  .../Include/VirtualKeyboardFeature.dsc                         | 3
> ++-
> >  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> | 1 +
> >  Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> | 1 +
> >  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> | 1 +
> >  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc         |
> 3 ++-
> >  Platform/Intel/BoardModulePkg/BoardModulePkg.dsc               |
> 3 ++-
> >  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc    | 3
> ++-
> >  Platform/Intel/QuarkPlatformPkg/Quark.dsc                      |
> 1 +
> >  Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc                   |
> 1 +
> >  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc           | 3
> ++-
> >  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc            | 3
> ++-
> >  Platform/LeMaker/CelloBoard/CelloBoard.dsc                     |
> 1 +
> >  Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> | 1 +
> >  Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc               | 1
> +
> >  Platform/RaspberryPi/RPi3/RPi3.dsc                             |
> 3 ++-
> >  Platform/RaspberryPi/RPi4/RPi4.dsc                             |
> 3 ++-
> >  Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc     |
> 1 +
> >  .../U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc       |
> 1 +
> >  Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc           | 1
> +
> >  Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc   | 1
> +
> >  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc    | 1
> +
> >  Silicon/Hisilicon/Hisilicon.dsc.inc                            | 1 +
> >  Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc    | 1 +
> >  Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc              | 3 ++-
> >  Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc        | 3 ++-
> >  Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc                      |
> 3 ++-
> >  Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc      | 1 +
> >  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc                  |
> 1 +
> >  Silicon/NXP/NxpQoriqLs.dsc.inc                                 |
> 1 +
> >  Silicon/Openmoko/Openmoko.dsc
> | 1 +
> >  Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc              | 1 +
> >  Silicon/Synopsys/DesignWare/DesignWare.dsc                     |
> 1 +
> >  Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc
> | 1 +
> >  47 files changed, 70 insertions(+), 23 deletions(-)
> >
> > --
> > 2.18.0.windows.1
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72947): https://edk2.groups.io/g/devel/message/72947
Mute This Topic: https://groups.io/mt/81395127/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list