[edk2-devel] [PATCH] MdeModulePkg AtaAtapiPassThru: Always do S.M.A.R.T. check if device support

[Wu, Hao A]

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of
> gaoliming
> Sent: Monday, November 1, 2021 5:46 PM
> To: devel at edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu at intel.com>; Ni, Ray <ray.ni at intel.com>
> Subject: [edk2-devel] [PATCH] MdeModulePkg AtaAtapiPassThru: Always do
> S.M.A.R.T. check if device support
> 
> If S.M.A.R.T. has been enabled, it can be checked.


A minor comment. I think the log message can be refined a little bit to:
If S.M.A.R.T. is supported, it can be checked.

The code change looks good to me:
Reviewed-by: Hao A Wu <hao.a.wu at intel.com>

Best Regards,
Hao Wu


> 
> Signed-off-by: Liming Gao <gaoliming at byosoft.com.cn>
> Cc: Hao A Wu <hao.a.wu at intel.com>
> Cc: Ray Ni <ray.ni at intel.com>
> ---
>  .../Bus/Ata/AtaAtapiPassThru/AhciMode.c       | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
> b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
> index 1053695b3b..a2831de65c 100644
> --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
> +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
> @@ -1833,18 +1833,17 @@ AhciAtaSmartSupport (
>                     ATA_ATAPI_TIMEOUT,
>                     NULL
>                     );
> -
> -        if (!EFI_ERROR (Status)) {
> -          Status = AhciAtaSmartReturnStatusCheck (
> -                     PciIo,
> -                     AhciRegisters,
> -                     (UINT8)Port,
> -                     (UINT8)PortMultiplier,
> -                     AtaStatusBlock
> -                     );
> -        }
>        }
>      }
> +
> +    AhciAtaSmartReturnStatusCheck (
> +      PciIo,
> +      AhciRegisters,
> +      (UINT8)Port,
> +      (UINT8)PortMultiplier,
> +      AtaStatusBlock
> +      );
> +
>      DEBUG ((EFI_D_INFO, "Enabled S.M.A.R.T feature at port [%d]
> PortMultiplier [%d]!\n",
>              Port, PortMultiplier));
>    }
> --
> 2.27.0.windows.1
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83087): https://edk2.groups.io/g/devel/message/83087
Mute This Topic: https://groups.io/mt/86735618/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-