[edk2-devel] Progress on getting Uncrustify working for EDK2?

[Michael D Kinney]

Submodule within which repo?  What would be the proposed location?

Would a fork of uncrustify maintained as a repo under TianoCore work as well?

There are CI checks (including extensive unit tests) and release generation that are built into uncrustify repo and I do not know if those will be functional if it is maintained as a submodule.

Thanks,

Mike

> -----Original Message-----
> From: Leif Lindholm <leif at nuviainc.com>
> Sent: Tuesday, November 9, 2021 4:37 AM
> To: Gerd Hoffmann <kraxel at redhat.com>
> Cc: devel at edk2.groups.io; Kinney, Michael D <michael.d.kinney at intel.com>; Andrew Fish <afish at apple.com>; Marvin Häuser
> <mhaeuser at posteo.de>; Michael Kubacki <Michael.Kubacki at microsoft.com>; mikuback at linux.microsoft.com; rebecca at nuviainc.com;
> Bret Barkelew <Bret.Barkelew at microsoft.com>
> Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?
> 
> On Tue, Nov 09, 2021 at 09:40:02 +0100, Gerd Hoffmann wrote:
> >   Hi,
> >
> > >   3.  Require use of uncrustify tool before submitting patch review emails or PRs.
> > >      *   The required version would be a formally released version  from the fork maintained by Michael Kubacki until
> the changes can be upstreamed.
> > >      *   https://dev.azure.com/projectmu/Uncrustify
> >
> > Can we please *first* get the changes merged to upstream uncrustify?
> >
> > That'll make the whole process much less painful because the usual
> > software repositories (linux distro packages, macos homebrew, ...)
> > can be used to install uncrustify then, and it's also less confusing if
> > developers don't have to juggle with different uncrustify variants
> > (upstream vs. edk2).
> 
> Whilst I agree in principle...
> 
> This means postponing automated coding style changes until 2023
> (Debian stable), 2025 (Ubuntu LTS), ??? (RHEL10), or even later
> ... and I'd rather not.
> 
> I like Marvin's suggestion of a submodule. Which we could drop once
> no longer needed.
> 
> /
>     Leif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83512): https://edk2.groups.io/g/devel/message/83512
Mute This Topic: https://groups.io/mt/84932137/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-