[edk2-devel] [PATCH V5 3/3] SecurityPkg: Support CcMeasurementProtocol in DxeTpmMeasurementLib

[Min Xu]

On November 8, 2021 10:18 PM, Sami Mujawar wrote:
> Hi Min,
> 
> Thank you for the updated patch.
> 
> I have a minor suggestion marked inline as [SAMI]. Otherwise, these changes
> look good to me.
> 
> Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>
> 
> > +  @retval EFI_SUCCESS           Operation completed successfully.
> > +  @retval EFI_UNSUPPORTED       CC guest not available.
> > +  @retval EFI_OUT_OF_RESOURCES  Out of memory.
> > +  @retval EFI_DEVICE_ERROR      The operation was unsuccessful.
> > +**/
> > +EFI_STATUS
> > +CcMeasureAndLogData (
> > +  IN UINT32             PcrIndex,
> > +  IN UINT32             EventType,
> > +  IN VOID               *EventLog,
> > +  IN UINT32             LogLen,
> > +  IN VOID               *HashData,
> > +  IN UINT64             HashDataLen
> > +  )
> [SAMI] I think this function can be made static and the CcProtocol pointer
> could be passed as the first argument.
> Similarly, the other functions Tpm20MeasureAndLogData() and
> Tpm12MeasureAndLogDat() could also be made static.
> [/SAMI]
Ok. It will be updated in the next version.

Thanks
Min


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83533): https://edk2.groups.io/g/devel/message/83533
Mute This Topic: https://groups.io/mt/86881262/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-