[edk2-devel] [Patch 1/1] .azurepipelines/templates: Update max pipeline job time to 2 hours

[Michael D Kinney]

Hi Michael,

I would like to see some optimization work applied to the ECC tool to see if
we can reduce the time that tool requires.  If we find some easy improvements
that allow larger patch series to complete in 60 minutes, then I am in favor
of reducing back down to 60 minutes.

Unless we actually see jobs running more than 60 minutes or hitting the 120
minute timeout, I do not see this patch causing problems.  We can do an audit
of PRs once is a while to see what the job execution times are.

If we do want to reduce, it will have to be a separate patch after uncrustify
set of PRs is applied.

Mike

> -----Original Message-----
> From: Michael Kubacki <mikuback at linux.microsoft.com>
> Sent: Tuesday, November 23, 2021 4:49 PM
> To: devel at edk2.groups.io; Kinney, Michael D <michael.d.kinney at intel.com>
> Cc: Sean Brogan <sean.brogan at microsoft.com>; Bret Barkelew <Bret.Barkelew at microsoft.com>; Liming Gao
> <gaoliming at byosoft.com.cn>; Michael Kubacki <michael.kubacki at microsoft.com>
> Subject: Re: [edk2-devel] [Patch 1/1] .azurepipelines/templates: Update max pipeline job time to 2 hours
> 
> Hi Mike,
> 
> Is the plan to keep it at a 2 hour limit indefinitely (not just for
> these large series currently outstanding)?
> 
> Thanks,
> Michael
> 
> On 11/23/2021 7:44 PM, Michael D Kinney wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3750
> >
> > Large patches that modify a large number of files(e.g uncrustify)
> > take longer to process through CI checks such as ECC.  Increase
> > the max job time from 1 hour to 2 hours to accommodate larger patch
> > series.
> >
> > Cc: Sean Brogan <sean.brogan at microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew at microsoft.com>
> > Cc: Liming Gao <gaoliming at byosoft.com.cn>
> > Cc: Michael Kubacki <michael.kubacki at microsoft.com>
> > Signed-off-by: Michael D Kinney <michael.d.kinney at intel.com>
> > ---
> >   .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
> > index d5b16c127f58..244cffdbfaba 100644
> > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > @@ -17,7 +17,7 @@ parameters:
> >   jobs:
> >
> >   - job: Build_${{ parameters.tool_chain_tag }}
> > -
> > +  timeoutInMinutes: 120
> >     #Use matrix to speed up the build process
> >     strategy:
> >       matrix:
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84006): https://edk2.groups.io/g/devel/message/84006
Mute This Topic: https://groups.io/mt/87272166/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-