[edk2-devel] [PATCH 2/2] Allow wildcards in hostname

[Yao, Jiewen]

It seems the Bugzilla only describes the ECC, but no much info on why we need allow wildcards in hostname.

The git log in mu is also unclear to me - "This enables certain local network recovery stories. May re-evaluate as those stories change. "

I am OK with ECC change, and give R-B.

But I would like to understand more on why we need allow wildcards in general. What are the stories?

If this is only for "recovery stories", should we also allow wildcards in recovery boot path?

For example, should we have a PCD to platform owner make decision? E.g. normal boot - NO. recovery boot - YES ?

Thank you
Yao Jiewen



> -----Original Message-----
> From: Vineel Kovvuri <vineel.kovvuri at gmail.com>
> Sent: Tuesday, October 12, 2021 1:38 PM
> To: devel at edk2.groups.io; Yao, Jiewen <jiewen.yao at intel.com>;
> sean.brogan at microsoft.com; bret.barkelew at microsoft.com;
> Michael.Turner at microsoft.com
> Cc: Vineel Kovvuri <vineelko at microsoft.com>
> Subject: [PATCH 2/2] Allow wildcards in hostname
> 
> This PR is cherry-picked from
> https://github.com/microsoft/mu_basecore/commit/d0c7733400c35722499ee
> dcd4279042a9bcb0eb4
> 
> BugZilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3679
> 
> Signed-off-by: Vineel Kovvuri <vineelko at microsoft.com>
> ---
>  NetworkPkg/HttpDxe/HttpsSupport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/NetworkPkg/HttpDxe/HttpsSupport.c
> b/NetworkPkg/HttpDxe/HttpsSupport.c
> index 7e0bf85c3c..0f28ae9447 100644
> --- a/NetworkPkg/HttpDxe/HttpsSupport.c
> +++ b/NetworkPkg/HttpDxe/HttpsSupport.c
> @@ -625,7 +625,7 @@ TlsConfigureSession (
>    //
>    HttpInstance->TlsConfigData.ConnectionEnd       = EfiTlsClient;
>    HttpInstance->TlsConfigData.VerifyMethod        = EFI_TLS_VERIFY_PEER;
> -  HttpInstance->TlsConfigData.VerifyHost.Flags    =
> EFI_TLS_VERIFY_FLAG_NO_WILDCARDS;
> +  HttpInstance->TlsConfigData.VerifyHost.Flags    =
> EFI_TLS_VERIFY_FLAG_NONE;
>    HttpInstance->TlsConfigData.VerifyHost.HostName = HttpInstance-
> >RemoteHost;
>    HttpInstance->TlsConfigData.SessionState        = EfiTlsSessionNotStarted;
> 
> --
> 2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81848): https://edk2.groups.io/g/devel/message/81848
Mute This Topic: https://groups.io/mt/86257811/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-