[edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug

Oram, Isaac W isaac.w.oram at intel.com
Fri Oct 15 01:13:11 UTC 2021


Pushed as 8194edc4af71799f163fe9735d0059dd90079ecc

-----Original Message-----
From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Oram, Isaac W
Sent: Wednesday, September 22, 2021 2:35 PM
To: devel at edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug

Fix issue with missing debug messages on ESPI_ENABLE configuration.

Cc: Chasel Chiu <chasel.chiu at intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram at intel.com>
---
 Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c b/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c
index fa695358bf..8a93f41678 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c
+++ b/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c
@@ -116,6 +116,13 @@ IsAspeedPresent (
  IoWrite8 (ASPEED2500_SIO_INDEX_PORT, REG_LOGICAL_DEVICE);
  IoWrite8 (ASPEED2500_SIO_DATA_PORT, ASPEED2500_SIO_UART1);
  if (IoRead8 (ASPEED2500_SIO_DATA_PORT) == ASPEED2500_SIO_UART1) {
+  //
+  // In ESPI mode, assume this SIO logic device always present.
+  //
+#ifdef ESPI_ENABLE
+  DeviceID = 0;
+  PresenceStatus = TRUE;
+#else
   //
   //right now, maybe it is ASPEED. to detect the  device ID.
   //
@@ -143,6 +150,7 @@ IsAspeedPresent (
   if ((DeviceID & 0xff0000ff) == 0x04000003) {
    PresenceStatus = TRUE;
   }
+#endif
  }
  IoWrite8 (ASPEED2500_SIO_INDEX_PORT, ASPEED2500_SIO_LOCK);
  return PresenceStatus;
-- 
2.27.0.windows.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82070): https://edk2.groups.io/g/devel/message/82070
Mute This Topic: https://groups.io/mt/85800898/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list