[edk2-devel] [PATCH] DynamicTablesPkg: Fix unitialized variable use

[Sami Mujawar]

Hi Moritz,

Thank you for this fix.

Reviewed-by: Sami Mujawar <sami.mujawar at arm.com>

Regards,

Sami Mujawar

On 20/10/2021 06:21 AM, Moritz Fischer wrote:
> In the success case we should return EFI_SUCCESS rather than returning
> a potentially unitialized value of Status.
>
> Cc: Sami Mujawar <Sami.Mujawar at arm.com>
> Cc: Alexei Fedorov <Alexei.Fedorov at arm.com>
> Signed-off-by: Moritz Fischer <moritzf at google.com>
> ---
>   .../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c      | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
> index 0bdb6c24c5bb..e9e1a85ede63 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
> @@ -91,7 +91,7 @@ LinkRdNode (
>       *NewRdNode = RdNode;
>     }
>   
> -  return Status;
> +  return EFI_SUCCESS;
>   
>   error_handler:
>     Status1 = AmlDeleteTree ((AML_NODE_HEADER*)RdNode);



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82417): https://edk2.groups.io/g/devel/message/82417
Mute This Topic: https://groups.io/mt/86458612/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-