[edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc

Fri Oct 29 05:09:28 UTC 2021

Hi JP,

I had some problems using the patch emails.

Due to the size of the patch to remove the Python 2.x files, I reviewed
the 4 commits in the branch you provided instead.

	https://github.com/jpshivakavi/edk2-libc/tree/remove_py272_support

Comments
=========
1) StdLib/ReadMe.txt and StdLibPrivateInternalFiles/ReadMe.txt have references to Python 2.
   I recommend you update them to match AppPkg/ReadMe.txt updates you did.

With the above updates:

Series Reviewed-by: Michael D Kinney <michael.d.kinney at intel.com>

Thanks,

Mike

> -----Original Message-----
> From: Jayaprakash, N <n.jayaprakash at intel.com>
> Sent: Wednesday, October 27, 2021 8:01 PM
> To: Kinney, Michael D <michael.d.kinney at intel.com>; devel at edk2.groups.io
> Cc: Rebecca Cran <rebecca at nuviainc.com>
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc
> 
> Hi Mike,
> 
> Could you look into this PR?
> 
> Regards,
> JP
> 
> -----Original Message-----
> From: Jayaprakash, N
> Sent: 25 October 2021 22:10
> To: Kinney, Michael D <michael.d.kinney at intel.com>; devel at edk2.groups.io
> Cc: Rebecca Cran <rebecca at nuviainc.com>
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc
> 
> Hi Mike,
> 
> I have send V2 version of patch series to remove complete Py 2.7 support(including py 2.7.2 and py 2.7.10 versions
> removal).
> Separate patches created for code and document changes.
> 
> There was some issue with running send email on my system, you would have got multiple emails with the same set of
> patches.
> Please ignore the duplicate patch emails.
> 
> These are the patches sent for removing py 2.7 support completely from edk2-libc.
>   AppPkg/Applications/Python: To remove the py2.7.2 uefi port code                              -    Code changes 2.7.2
>   AppPkg/Applications/Python: to remove document references to py2.7.2                    -   Document changes 2.7.2
>   AppPkg/Applications/Python: to remove py2.7.10 support from edk2-libc                    -   Code changes 2.7.10
>   AppPkg/Applications/Python: to remove py2.7.10 references from edk2-libc               -   Document changes 2.7.10
> 
> Please review and do the needful.
> 
> Regards,
> JP
> 
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney at intel.com>
> Sent: 23 October 2021 22:40
> To: Jayaprakash, N <n.jayaprakash at intel.com>; devel at edk2.groups.io; Kinney, Michael D <michael.d.kinney at intel.com>
> Cc: Rebecca Cran <rebecca at nuviainc.com>
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc
> 
> Can you please send V2 of the patch series with the Readme changes in its own patch?
> 
> Thanks,
> 
> Mike
> 
> > -----Original Message-----
> > From: Jayaprakash, N <n.jayaprakash at intel.com>
> > Sent: Friday, October 22, 2021 4:23 AM
> > To: Kinney, Michael D <michael.d.kinney at intel.com>;
> > devel at edk2.groups.io
> > Cc: Rebecca Cran <rebecca at nuviainc.com>
> > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1]
> > AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc
> >
> > Hi Mike,
> >
> > Could you look into this and let me know if there is anything else need to be done.
> >
> > Regards,
> > JP
> > -----Original Message-----
> > From: Jayaprakash, N
> > Sent: 20 October 2021 23:15
> > To: Kinney, Michael D <michael.d.kinney at intel.com>;
> > devel at edk2.groups.io
> > Cc: Rebecca Cran <rebecca at nuviainc.com>
> > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1]
> > AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc
> >
> > Hi Mike,
> >
> > Thanks for the review comments.
> >
> > The PythonReadMe.txt available @ https://github.com/tianocore/edk2-
> > libc/blob/master/AppPkg/Applications/Python/PythonReadMe.txt
> > is the readme file for Py2.7.2 and we don't need to retain this file.
> > So I have deleted this file as part of the patch sent for review.
> >
> > Py 2.7.10 and Py 3.6.8 have their respective readme files as
> > Py2710ReadMe.txt @ https://github.com/jpshivakavi/edk2-
> > libc/tree/master/AppPkg/Applications/Python/Python-2.7.10
> > Py368ReadMe.txt @
> > https://github.com/jpshivakavi/edk2-libc/tree/master/AppPkg/Applicatio
> > ns/Python/Python-3.6.8
> >
> >
> > Besides this, I have taken care of all the other documentation changes
> > required as given below
> >
> > Updated the readme.md file from this location and removed the
> > reference to Py2.7.2 license
> > https://github.com/tianocore/edk2-libc/blob/master/Readme.md
> >
> > 	AppPkg/Applications/Python/Python-2.7.2/Tools/pybench
> > 	AppPkg/Applications/Python/Python-2.7.2
> >
> > Updated the readme.txt from the below location to remove references to 2.7.2 and replace it with 3.6.8 references.
> > https://github.com/tianocore/edk2-libc/blob/master/AppPkg/ReadMe.txt
> > Also updated the version of this readme file along with the date
> > 		   Version 1.03
> >                                  18 Oct. 2021
> >
> >
> > Besides documentation changes following changes have been done to
> > delete py 2.7.2 support from edk2-libc Updated the AppPkg.dsc file to remove the Python 2.7.2 inf references.
> > https://github.com/jpshivakavi/edk2-libc/blob/remove_py272_support/App
> > Pkg/AppPkg.dsc
> >
> >
> > Removed all files and folders corresponding to Py2.7.2 support from
> > https://github.com/jpshivakavi/edk2-libc/tree/master/AppPkg/Applicatio
> > ns/Python
> > Efi\
> > Ia32\
> > PyMod-2.7.2\
> > Python-2.7.2\
> > X64\
> > PythonCore.inf    // Inf file for py 2.7.2
> > PythonReadme.txt // Readme file for Py 2.7.2
> >
> >
> > Let me know if there is anything else needed.
> >
> > Regards,
> > JP
> >
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney at intel.com>
> > Sent: 20 October 2021 21:35
> > To: devel at edk2.groups.io; Jayaprakash, N <n.jayaprakash at intel.com>;
> > Kinney, Michael D <michael.d.kinney at intel.com>
> > Cc: Rebecca Cran <rebecca at nuviainc.com>
> > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1]
> > AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc
> >
> > Hi JP,
> >
> > Can you also update the documentation to remove references to Python 2.x or update for Python 3.x?
> >
> > For example, the following file has Python 2.x references.
> >
> > https://github.com/tianocore/edk2-libc/blob/master/AppPkg/Applications
> > /Python/PythonReadMe.txt
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of
> > > Jayaprakash, N
> > > Sent: Tuesday, October 19, 2021 8:43 PM
> > > To: devel at edk2.groups.io
> > > Cc: Rebecca Cran <rebecca at nuviainc.com>; Kinney, Michael D
> > > <michael.d.kinney at intel.com>; Jayaprakash, N
> > > <n.jayaprakash at intel.com>
> > > Subject: [edk2-devel] [edk2-libc Patch 1/1]
> > > AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc
> > >
> > >
> > >
> > > 
> > >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82909): https://edk2.groups.io/g/devel/message/82909
Mute This Topic: https://groups.io/mt/86457669/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-