回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py
gaoliming
gaoliming at byosoft.com.cn
Thu Sep 2 02:09:41 UTC 2021
I upload it again. Now, it has been merged.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 duntan
> 发送时间: 2021年9月2日 9:24
> 收件人: gaoliming <gaoliming at byosoft.com.cn>; devel at edk2.groups.io
> 抄送: 'Sean Brogan' <sean.brogan at microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew at microsoft.com>; Kinney, Michael D
> <michael.d.kinney at intel.com>
> 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in
> gate-build-job.yml and CISetting.py
>
> Hi Liming,
>
> I have seen the link to push my commits to master of edk2. The result shows
> that the Ci test failed in ArmPlatformPkg. But I think my commits will not
> affect the ArmPlatformPkg. Here is the link.
> https://github.com/tianocore/edk2/pull/1940the
> So is there anything I need to do?
>
> Thanks,
> Dun
> -----Original Message-----
> From: Tan, Dun
> Sent: Wednesday, September 1, 2021 11:32 AM
> To: gaoliming <gaoliming at byosoft.com.cn>; devel at edk2.groups.io
> Cc: 'Sean Brogan' <sean.brogan at microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew at microsoft.com>; Kinney, Michael D
> <michael.d.kinney at intel.com>
> Subject: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in
> gate-build-job.yml and CISetting.py
>
> Hi Liming,
>
> The patch to fix the build issue has been merged this morning.
> Would you please help to merge the two patches to enable core CI for
> UefiPayloadPkg?
>
> Thanks,
> Dun
> -----Original Message-----
> From: gaoliming <gaoliming at byosoft.com.cn>
> Sent: Tuesday, August 31, 2021 9:05 AM
> To: Tan, Dun <dun.tan at intel.com>; devel at edk2.groups.io
> Cc: 'Sean Brogan' <sean.brogan at microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew at microsoft.com>; Kinney, Michael D
> <michael.d.kinney at intel.com>
> Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg
> in gate-build-job.yml and CISetting.py
>
> Dun:
> This PR also includes one additional commit to fix the build issue. Have you
> send the patch for it?
>
> For this patch set, Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn>.
> It will be merged after the build issue has been fixed.
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Tan, Dun <dun.tan at intel.com>
> > 发送时间: 2021年8月30日 16:31
> > 收件人: gaoliming <gaoliming at byosoft.com.cn>; devel at edk2.groups.io
> > 抄送: 'Sean Brogan' <sean.brogan at microsoft.com>; 'Bret Barkelew'
> > <Bret.Barkelew at microsoft.com>; Kinney, Michael D
> > <michael.d.kinney at intel.com>
> > 主题: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg
> > in gate-build-job.yml and CISetting.py
> >
> > Hi Liming,
> >
> > Here is the link of the PR to verify the change in Tiano EDKII. It
> > passed the CI by GCC and VS both.
> > https://github.com/tianocore/edk2/pull/1931
> >
> > Thanks,
> > Dun
> > -----Original Message-----
> > From: gaoliming <gaoliming at byosoft.com.cn>
> > Sent: Monday, August 30, 2021 11:26 AM
> > To: devel at edk2.groups.io; Tan, Dun <dun.tan at intel.com>
> > Cc: 'Sean Brogan' <sean.brogan at microsoft.com>; 'Bret Barkelew'
> > <Bret.Barkelew at microsoft.com>; Kinney, Michael D
> > <michael.d.kinney at intel.com>
> > Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add
> > UefiPayloadPkg in gate-build-job.yml and CISetting.py
> >
> > Dun:
> > I don't see the issues to enable UefiPayloadPkg in CI. Have you
> > created the private PR to verify this change?
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表 duntan
> > > 发送时间: 2021年8月24日 17:24
> > > 收件人: devel at edk2.groups.io
> > > 抄送: Sean Brogan <sean.brogan at microsoft.com>; Bret Barkelew
> > > <Bret.Barkelew at microsoft.com>; Kinney, Michael D
> > > <michael.d.kinney at intel.com>; Liming Gao <gaoliming at byosoft.com.cn>
> > > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg
> > > in gate-build-job.yml and CISetting.py
> > >
> > > Hi all,
> > > Since the CI for UefiPayloadPkg is important to our develop
> > > progress, would you please speed up the review process? Thanks a lot!
> > >
> > > Thanks,
> > > Dun Tan
> > > -----Original Message-----
> > > From: Tan, Dun <dun.tan at intel.com>
> > > Sent: Friday, August 20, 2021 2:44 PM
> > > To: devel at edk2.groups.io
> > > Cc: Sean Brogan <sean.brogan at microsoft.com>; Bret Barkelew
> > > <Bret.Barkelew at microsoft.com>; Kinney, Michael D
> > > <michael.d.kinney at intel.com>; Liming Gao <gaoliming at byosoft.com.cn>;
> > > Tan, Dun <dun.tan at intel.com>
> > > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in
> > > gate-build-job.yml and CISetting.py
> > >
> > > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for
> > > UefiPayloadPkg.
> > > Add UefiPayloadPkg to supported Packages in CISettings.
> > >
> > > Cc: Sean Brogan <sean.brogan at microsoft.com>
> > > Cc: Bret Barkelew <Bret.Barkelew at microsoft.com>
> > > Cc: Michael D Kinney <michael.d.kinney at intel.com>
> > > Cc: Liming Gao <gaoliming at byosoft.com.cn>
> > > Signed-off-by: DunTan <dun.tan at intel.com>
> > > ---
> > > .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> > > .pytool/CISettings.py | 3 ++-
> > > 2 files changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > > b/.azurepipelines/templates/pr-gate-build-job.yml
> > > index 207acc7631..d5b16c127f 100644
> > > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > > @@ -48,6 +48,9 @@ jobs:
> > > TARGET_SECURITY:
> > > Build.Pkgs: 'SecurityPkg'
> > > Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > > + TARGET_UEFIPAYLOAD:
> > > + Build.Pkgs: 'UefiPayloadPkg'
> > > + Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > > TARGET_PLATFORMS:
> > > # For Platforms only check code. Leave it to Platform CI
> > > # to build them.
> > > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index
> > > 96e6baa519..ce330e2c73 100644
> > > --- a/.pytool/CISettings.py
> > > +++ b/.pytool/CISettings.py
> > > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager,
> > > UpdateSettingsManager, SetupSettingsManag
> > > "CryptoPkg",
> > > "UnitTestFrameworkPkg",
> > > "OvmfPkg",
> > > - "RedfishPkg"
> > > + "RedfishPkg",
> > > + "UefiPayloadPkg"
> > > )
> > >
> > > def GetArchitecturesSupported(self):
> > > --
> > > 2.31.1.windows.1
> > >
> > >
> > >
> > >
> > >
> >
> >
>
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80145): https://edk2.groups.io/g/devel/message/80145
Mute This Topic: https://groups.io/mt/85319448/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list