[edk2-devel] [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic and set it accordingly

Zhang, Xiaoqiang xiaoqiang.zhang at intel.com
Wed Sep 22 08:49:57 UTC 2021


Thanks Chasel!

Best Regards,
Xiaoqiang Zhang

-----Original Message-----
From: Chiu, Chasel <chasel.chiu at intel.com> 
Sent: Wednesday, September 22, 2021 4:39 PM
To: Zhang, Xiaoqiang <xiaoqiang.zhang at intel.com>; devel at edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Zeng, Star <star.zeng at intel.com>
Subject: RE: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic and set it accordingly


Patch pushed: https://github.com/tianocore/edk2/commit/f334c5a41dc4702b1c767c6614025aa2f802f9a4

Thanks,
Chasel


> -----Original Message-----
> From: Zhang, Xiaoqiang <xiaoqiang.zhang at intel.com>
> Sent: Thursday, September 16, 2021 11:45 AM
> To: devel at edk2.groups.io
> Cc: Zhang, Xiaoqiang <xiaoqiang.zhang at intel.com>; Chiu, Chasel 
> <chasel.chiu at intel.com>; Desimone, Nathaniel L 
> <nathaniel.l.desimone at intel.com>; Zeng, Star <star.zeng at intel.com>
> Subject: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection 
> dynamic and set it accordingly
> 
> From: Zhang Xiaoqiang <xiaoqiang.zhang at intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3632
> 
> PcdFspModeSelection will be used to set FSP mode.
> Make PcdFspModeSelection dynamic and set it accordingly.
> 
> Signed-off-by: Zhang Xiaoqiang <xiaoqiang.zhang at intel.com>
> Cc: Chasel Chiu <chasel.chiu at intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
> Cc: Star Zeng <star.zeng at intel.com>
> ---
>  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> index a3b9363779..b8dac1b574 100644
> --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> @@ -82,12 +82,6 @@
>    # @Prompt Skip FSP API from FSP wrapper.
> 
> 
> gIntelFsp2WrapperTokenSpaceGuid.PcdSkipFspApi|0x00000000|UINT32|0x4
> 0000009
> 
> 
> 
> -  ## This PCD decides how Wrapper code utilizes FSP
> 
> -  # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without 
> calling FSP API)
> 
> -  # 1: API mode (FSP Wrapper will call FSP API)
> 
> -  #
> 
> -
> gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x00000001|UIN
> T8|0x4000000A
> 
> -
> 
>    ## This PCD decides how FSP is measured
> 
>    # 1) The BootGuard ACM may already measured the FSP component, such 
> as FSPT/FSPM.
> 
>    # We need a flag (PCD) to indicate if there is need to do such FSP 
> measurement or NOT.
> 
> @@ -106,6 +100,12 @@
> 
> gIntelFsp2WrapperTokenSpaceGuid.PcdFspMeasurementConfig|0x0000000
> 0|UINT32|0x4000000B
> 
> 
> 
>  [PcdsFixedAtBuild, PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx]
> 
> +  ## This PCD decides how Wrapper code utilizes FSP
> 
> +  # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without
> calling FSP API)
> 
> +  # 1: API mode (FSP Wrapper will call FSP API)
> 
> +  #
> 
> +
> gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x00000001|UIN
> T8|0x4000000A
> 
> +
> 
>    #
> 
>    ## These are the base address of FSP-M/S
> 
>    #
> 
> --
> 2.32.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80987): https://edk2.groups.io/g/devel/message/80987
Mute This Topic: https://groups.io/mt/85644790/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list