回复: [edk2-devel] 回复: [PATCH v1 0/4] Set default Makefile name

[gaoliming]

Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel at edk2.groups.io <devel at edk2.groups.io> 代表
> PierreGondois
> 发送时间: 2021年9月24日 19:57
> 收件人: gaoliming <gaoliming at byosoft.com.cn>; devel at edk2.groups.io; 'Bob
> Feng' <bob.c.feng at intel.com>; 'Sami Mujawar' <sami.mujawar at arm.com>
> 抄送: 'Christopher Jones' <Christopher.Jones at arm.com>
> 主题: Re: [edk2-devel] 回复: [PATCH v1 0/4] Set default Makefile name
> 
> Hi Liming,
> 
> I created: https://bugzilla.tianocore.org/show_bug.cgi?id=3653
> 
> Regards,
> 
> Pierre
> 
> On 9/24/21 1:48 AM, gaoliming wrote:
> > Pierre:
> >   Can you submit BZ for this change request?
> >
> > Thanks
> > Liming
> >> -----邮件原件-----
> >> 发件人: Pierre.Gondois at arm.com <Pierre.Gondois at arm.com>
> >> 发送时间: 2021年9月23日 16:59
> >> 收件人: devel at edk2.groups.io; Bob Feng <bob.c.feng at intel.com>;
> Liming
> >> Gao <gaoliming at byosoft.com.cn>; Sami Mujawar
> <sami.mujawar at arm.com>
> >> 主题: [PATCH v1 0/4] Set default Makefile name
> >>
> >> From: Pierre Gondois <Pierre.Gondois at arm.com>
> >>
> >> A Makefile name is not set in BaseTools when only building modules
> >> or libraries. This patch-set sets a default Makefile name for the
> >> "build" command.
> >>
> >> The patch-set also:
> >> - Removes unsused Makefile variables
> >> - Removes hard-coded references to "target.txt" and "tools_def.txt"
> >>
> >> The changes can be seen at:
> >>
> https://github.com/PierreARM/edk2/tree/1868_BaseTools_build_py_correcti
> >> ons_v1
> >>
> >> Pierre Gondois (4):
> >>   BaseTools/GenMake: Use ToolDefinition as fallback option
> >>   BaseTools/build: Set MakefileName
> >>   BaseTools: Remove Makefile/MakefileName fields
> >>   BaseTools: Remove hard-coded strings for target and tools_def
> >>
> >>  BaseTools/Source/Python/AutoGen/GenMake.py            |  8
> >> ++++----
> >>  BaseTools/Source/Python/AutoGen/ModuleAutoGen.py      |  1 -
> >>  BaseTools/Source/Python/GenFds/GenFds.py              |  4 ++--
> >>  .../Source/Python/GenFds/GenFdsGlobalVariable.py      |  4 ++--
> >>  BaseTools/Source/Python/TargetTool/TargetTool.py      |  3 ++-
> >>  BaseTools/Source/Python/Workspace/BuildClassObject.py |  2 --
> >>  BaseTools/Source/Python/Workspace/DscBuildData.py     |  9
> ++++-----
> >>  BaseTools/Source/Python/build/build.py                | 11
> ++++-------
> >>  8 files changed, 18 insertions(+), 24 deletions(-)
> >>
> >> --
> >> 2.17.1
> >
> >
> >
> >
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81258): https://edk2.groups.io/g/devel/message/81258
Mute This Topic: https://groups.io/mt/85939699/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-