[edk2-devel] [PATCH edk2-platforms v2 0/3] JunoPkg: Fix AcpiSsdtRootPci.asl to use spaces and reserve ECAM area

[Rebecca Cran]

Could someone review these, and if they look good push them please?


Thanks.

Rebecca Cran


On 3/19/22 14:13, Rebecca Cran wrote:
> I noticed Linux reports a firmware bug with the current Juno ACPI
> tables. These patches fix it by reserving the ECAM area with a RES0
> device, while also converting AcpiSsdtRootPci.asl from tabs to spaces
> and using the standard Pcd from MdePkg for the ECAM base address.
>
> Changes between v1 and v2:
>
> - Removed the namespace prefix from the Pcd call in 2/3.
> - Updated the commit message in 3/3 to link to discussion about the new
>    warning message.
>
>
> Rebecca Cran (3):
>    Platform/ARM/JunoPkg: Convert AcpiSsdtRootPci.asl from tabs to spaces
>    Platform/ARM/JunoPkg: Use MdePkg PcdPciExpressBaseAddress for ECAM
>      addr
>    Platform/ARM/JunoPkg: Reserve the ECAM area in ACPI with RES0 device
>
>   Platform/ARM/JunoPkg/ArmJuno.dec                                                              |   4 +-
>   Platform/ARM/JunoPkg/AcpiTables/AcpiTables.inf                                                |   4 +
>   Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |   2 +-
>   Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf                                        |   2 +-
>   Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoLib.inf                                        |   2 +-
>   Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf                    |   2 +-
>   Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.h                               |   2 +-
>   Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      |   2 +-
>   Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/AcpiTables.c                                          |   2 +-
>   Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoMem.c                                          |   4 +-
>   Platform/ARM/JunoPkg/AcpiTables/AcpiSsdtRootPci.asl                                           | 301 ++++++++++----------
>   11 files changed, 172 insertions(+), 155 deletions(-)
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88336): https://edk2.groups.io/g/devel/message/88336
Mute This Topic: https://groups.io/mt/89895612/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-