[edk2-devel] [PATCH v1 1/1] .pytool/Plugin/UncrustifyCheck: Output file diffs by default

[Michael Kubacki]

It is printed in the error log. For your current PR:
https://github.com/tianocore/edk2/pull/2744

The results are printed in "Standard_Error_Output.log":
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=47584&view=ms.vss-test-web.build-test-results-tab&runId=346168&resultId=100012&paneView=attachments

These are the results:

"""
Files with formatting errors:
  Formatting errors in Library/ArmSmcLib/ArmSmc.c
  --- /home/vsts/work/1/s/ArmPkg/Library/ArmSmcLib/ArmSmc.c
  +++ 
/home/vsts/work/1/s/ArmPkg/Library/ArmSmcLib/ArmSmc.c.uncrustify_plugin
  @@ -25,10 +25,10 @@
  IN OUT UINTN  *Arg1 OPTIONAL,
  IN OUT UINTN  *Arg2 OPTIONAL,
  IN OUT UINTN  *Arg3 OPTIONAL
  -)
  +  )
  {
  ARM_SMC_ARGS  Args;
  -  UINTN    ErrorCode;
  +  UINTN         ErrorCode;

  ZeroMem (&Args, sizeof (ARM_SMC_ARGS));

  @@ -80,7 +80,7 @@
  IN     UINTN  Function,
  IN OUT UINTN  *Arg1 OPTIONAL,
  IN OUT UINTN  *Arg2 OPTIONAL,
  -  OUT UINTN *Arg3 OPTIONAL
  +  OUT UINTN     *Arg3 OPTIONAL
  )
  {
  return ArmCallSmc3 (Function, Arg1, Arg2, Arg3);
  @@ -102,7 +102,7 @@
  IN OUT UINTN  *Arg1 OPTIONAL,
  OUT UINTN     *Arg2 OPTIONAL,
  OUT UINTN     *Arg3 OPTIONAL
  -)
  +  )
  {
  return ArmCallSmc3 (Function, Arg1, Arg2, Arg3);
  }
"""

These diffs can get very verbose and will overwhelm people if printed to 
standard console output. They are cleanly separated here.

Thanks,
Michael

On 4/5/2022 10:31 AM, Rebecca Cran wrote:
> So your change in 56530dec1105f17455752675e4c90fb859c64836 didn't fix 
> anything, because we don't output TestSuites.xml to the console: if I 
> introduce a code style issue into a branch, CI still only prints the 
> following:
> 
> PROGRESS - --Running ArmPkg: Uncrustify Coding Standard Test NO-TARGET --
> WARNING - A file header template is not specified in the config file.
> WARNING - A function header template is not specified in the config file.
> ERROR - /home/vsts/work/1/s/ArmPkg/Library/ArmSmcLib/ArmSmc.c
> ERROR - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET 
> returned 1
> ERROR - Overall Build Status: Error
> PROGRESS - There were 1 failures out of 13 attempts
> 
> 
> Could we get the diff printed *there* too?
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88428): https://edk2.groups.io/g/devel/message/88428
Mute This Topic: https://groups.io/mt/89049118/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-