[edk2-devel] [PATCH] BaseTools/Conf: Fix Dynamic-Library-File template

Bob Feng bob.c.feng at intel.com
Tue Apr 26 03:52:44 UTC 2022


This patch looks good to me.

Reviewed-by: Bob Feng <bob.c.feng at intel.com>

-----Original Message-----
From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Jake Garver via groups.io
Sent: Friday, April 8, 2022 1:04 AM
To: devel at edk2.groups.io; jbrasen at nvidia.com; ashishsingha at nvidia.com
Cc: Jake Garver <jake at nvidia.com>
Subject: [edk2-devel] [PATCH] BaseTools/Conf: Fix Dynamic-Library-File template

In the Dynamic-Library-File template, add missing output file declarations.  These files are generated by the template and other rules explicitly depend on them.

This change resolves missing dependency issues we encountered while running a recursive make with job control.

Signed-off-by: Jake Garver <jake at nvidia.com>
---
 BaseTools/Conf/build_rule.template | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
index f401182344..4356623512 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -366,6 +366,8 @@
 
     <OutputFile>
         $(OUTPUT_DIR)(+)$(MODULE_NAME).efi
+        $(DEBUG_DIR)(+)$(MODULE_NAME).efi
+        $(OUTPUT_DIR)(+)$(MODULE_NAME).map
 
     <Command.MSFT, Command.INTEL, Command.RVCT, Command.CLANGPDB>
         "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS)
--
2.17.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89324): https://edk2.groups.io/g/devel/message/89324
Mute This Topic: https://groups.io/mt/90317800/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list